Skip to content

feat(core): add esm plugin logic - #248

Merged
BioPhoton merged 21 commits into
mainfrom
esm-plugin-logic
Nov 15, 2023
Merged

feat(core): add esm plugin logic#248
BioPhoton merged 21 commits into
mainfrom
esm-plugin-logic

Conversation

@BioPhoton

@BioPhotonBioPhoton commented Nov 14, 2023•
edited
Loading

Copy link
Copy Markdown
Collaborator

This PR is related to #92

⚠️ NOTICE:
This PR needs to get considered in #215 as it will simplify the way we test plugins ATM
cc @Tlacenka

It includes:

  • separate logic for default runner (RunnerConfig type)
    • add more tests to cover the adopted logic
  • add logic and tests for (RunnerFunction type)
  • Refactor Observer to OnProgress
  • refactor executePlugin logic
    • avoid duplicated parsing
    • handle runner types
    • improve types
  • resolvesCleanup runnerconfig  #177

closes#230#177

@BioPhoton
BioPhoton marked this pull request as ready for review November 14, 2023 14:26
@BioPhotonBioPhoton self-assigned this Nov 14, 2023
@BioPhotonBioPhoton changed the title refactor(core): add esm plugin logicfeat(core): add esm plugin logicNov 14, 2023
matejchalk
matejchalk requested changes Nov 14, 2023
View reviewed changes
Comment threadpackages/core/src/lib/implementation/execute-plugin.spec.ts Outdated
Comment threadpackages/models/src/lib/global-options.ts
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-runner.ts Outdated
Comment threadpackages/models/test/fixtures/runner-config.mock.ts Outdated
Comment threadpackages/core/src/lib/implementation/runner.ts Outdated
Comment threadpackages/core/src/lib/implementation/runner.spec.ts
@BioPhoton

BioPhoton commented Nov 14, 2023

Copy link
Copy Markdown
CollaboratorAuthor

Like it!! This is a nice feature and a really good cleanup

@BioPhotonBioPhoton added this to the 2. Integration milestone Nov 14, 2023
@BioPhotonBioPhoton mentioned this pull request Nov 15, 2023
Closed
matejchalk
matejchalk reviewed Nov 15, 2023
View reviewed changes
Comment threadpackages/core/src/lib/implementation/execute-plugin.ts Outdated
Comment threadpackages/models/src/lib/plugin-config-runner.ts
Comment threadpackages/utils/src/lib/execute-process.ts
BioPhotonand others added 2 commits November 15, 2023 14:16
@BioPhoton@matejchalk
Update packages/core/src/lib/implementation/execute-plugin.ts
8e59953
Co-authored-by: Matěj Chalk <34691111+matejchalk@users.noreply.github.com>
@BioPhoton
refactor: implement review
8ea1fc1
BioPhoton
BioPhoton commented Nov 15, 2023
View reviewed changes

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented all changes

@TlacenkaTlacenka mentioned this pull request Nov 15, 2023
Closed
20 tasks
@BioPhoton
BioPhoton merged commit 18d4e3a into mainNov 15, 2023
@BioPhoton
BioPhoton deleted the esm-plugin-logic branch November 15, 2023 15:56
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejchalkmatejchalkmatejchalk approved these changes

Assignees

@BioPhotonBioPhoton

Labels

🧩 core➕ enhancementnew feature or request

Projects

None yet

Milestone

2. Integration

Development

Successfully merging this pull request may close these issues.

Introduce new type for runner Cleanup runnerconfig

2 participants

@BioPhoton@matejchalk