Skip to content

feat(cli): implement compare command - #556

Merged
matejchalk merged 4 commits into
mainfrom
compare-command
Mar 12, 2024
Merged

feat(cli): implement compare command#556
matejchalk merged 4 commits into
mainfrom
compare-command

Conversation

@matejchalk

@matejchalkmatejchalk commented Mar 11, 2024

Copy link
Copy Markdown
Collaborator

Closes#482

@github-actionsgithub-actionsBot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 cli labels Mar 11, 2024
@nx-cloud

nx-cloudBot commented Mar 11, 2024•
edited
Loading

Copy link
Copy Markdown

☁️ Nx Cloud Report

CI is running/has finished running commands for commit becdb44. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 9 targets

Sent with 💌 from NxCloud.

@matejchalkmatejchalk added the ➕ enhancement new feature or request label Mar 11, 2024
BioPhoton
BioPhoton reviewed Mar 11, 2024
View reviewed changes
Comment threadpackages/cli/src/lib/compare/compare-command.ts
BioPhoton
BioPhoton reviewed Mar 11, 2024
View reviewed changes
Comment threadpackages/cli/src/lib/implementation/compare.options.ts
BioPhoton
BioPhoton reviewed Mar 11, 2024
View reviewed changes
Comment threadpackages/cli/src/lib/yargs-cli.integration.test.ts
BioPhoton
BioPhoton previously approved these changes Mar 11, 2024
View reviewed changes

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.
Nice new command! Whoop Whoop! 🎉

Tlacenka
Tlacenka reviewed Mar 12, 2024
View reviewed changes

@TlacenkaTlacenka left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well tested. 🧪
I tried the command as well and works as expected for me 😁

Have some concerns about the snapshot length and help documentation, otherwise good to go!

Comment threadpackages/cli/README.md Outdated
Comment threade2e/cli-e2e/tests/__snapshots__/help.e2e.test.ts.snap
Comment threade2e/cli-e2e/tests/compare.e2e.test.ts
Comment threade2e/cli-e2e/tests/compare.e2e.test.ts
Comment threade2e/cli-e2e/tests/compare.e2e.test.ts
Comment threade2e/cli-e2e/tests/__snapshots__/compare.e2e.test.ts.snap
Comment threade2e/cli-e2e/tests/__snapshots__/compare.e2e.test.ts.snap
Comment threade2e/cli-e2e/tests/__snapshots__/compare.e2e.test.ts.snap
Tlacenka
Tlacenka approved these changes Mar 12, 2024
View reviewed changes

@TlacenkaTlacenka left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🍻

@matejchalk
matejchalk merged commit 266947f into mainMar 12, 2024
@matejchalk
matejchalk deleted the compare-command branch March 12, 2024 12:28
@matejchalkmatejchalk mentioned this pull request Mar 12, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhotonBioPhotonBioPhoton approved these changes
+1 more reviewer
@TlacenkaTlacenkaTlacenka approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@matejchalkmatejchalk

Labels

🧩 cli➕ enhancementnew feature or request📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CLI compare command (2 report.json files => reports-diff.json)

3 participants

@matejchalk@Tlacenka@BioPhoton