Skip to content

build: update Nx 19 & other dependencies - #811

Merged
vmasek merged 45 commits into
mainfrom
nx-19-update
Dec 9, 2024
Merged

build: update Nx 19 & other dependencies#811
vmasek merged 45 commits into
mainfrom
nx-19-update

Conversation

@vmasek

@vmasekvmasek commented Sep 4, 2024•
edited
Loading

Copy link
Copy Markdown
Collaborator

closes#771
closes#776
closes#835

@vmasekvmasek added the 🌊 Nx Nx related issues label Sep 4, 2024
@vmasekvmasek self-assigned this Sep 4, 2024
@vmasek

vmasek commented Sep 4, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Investigation of failing CI in progress 👀

@vmasek
vmasekforce-pushed the nx-19-update branch 4 times, most recently from f30595f to 6e16658CompareSeptember 5, 2024 18:27
@vmasek
vmasekforce-pushed the nx-19-update branch 3 times, most recently from cd2ca75 to b3dd03dCompareSeptember 6, 2024 18:02
@vmasek
vmasekforce-pushed the nx-19-update branch 2 times, most recently from 9218855 to b994b9fCompareSeptember 6, 2024 18:45
@github-actionsgithub-actionsBot removed 📖 Project documentation improvements or additions to the project documentation 🧩 utils labels Sep 6, 2024
vmasek
vmasek commented Sep 24, 2024
View reviewed changes
Comment threade2e/cli-e2e/tests/print-config.e2e.test.ts Outdated
vmasek
vmasek commented Sep 25, 2024
View reviewed changes
Comment threade2e/cli-e2e/vite.config.e2e.ts Outdated
vmasek
vmasek commented Sep 25, 2024
View reviewed changes
Comment threadtesting/test-setup/src/lib/test-folder.setup.ts
@vmasek
test(plugin-eslint): add tsconfig for todos-app
814cf46
@code-pushup/cli-source:code-pushup task (run in CI) fails without it
@vmasek
refactor: code pushup core config type import
588ec76
@vmasek
refactor: reformat yargs file
676e1fa
@vmasek
build: remove unnecessary types property from package json as it is g…
321d21f
…enerated
@vmasek
build: remove unnecessary tslib dependency form sub packages as we do…
60cdd93
… not use import helpers
@vmasek
refactor: code pushup merge configs helper direct import
8622189
@vmasek
refactor: code pushup preset direct imports
f6462e4
@vmasek
refactor: correct examples dist import
c9122be
@vmasek
test: correct double file extension imports
1e042e6
@vmasek
test: correct path for args testing
697470e
@vmasek
refactor(nx-plugin): target specific deprecation with ignore
ef62518
@vmasek
build: set import helpers usage to explicit false to mitigate tslib
08fa7b9
@vmasek
build(nx-plugin): keep supported nx version at >17 and <=19
4b70f42
@vmasek
vmasekforce-pushed the nx-19-update branch 3 times, most recently from d0422c3 to 537362dCompareDecember 8, 2024 16:22
BioPhoton
BioPhoton reviewed Dec 9, 2024
View reviewed changes
Comment threade2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.ts
BioPhoton
BioPhoton reviewed Dec 9, 2024
View reviewed changes
Comment threade2e/cli-e2e/mocks/fixtures/existing-reports/code-pushup.config.ts
BioPhoton
BioPhoton reviewed Dec 9, 2024
View reviewed changes
Comment threadexamples/plugins/project.json
BioPhoton
BioPhoton reviewed Dec 9, 2024
View reviewed changes

@BioPhotonBioPhoton left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to touch all imports in the code base to migrate to nx v19?

I would really want to avoid this.

@vmasek

vmasek commented Dec 9, 2024•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Do we really need to touch all imports in the code base to migrate to nx v19?

I would really want to avoid this.

I know it is quite big change but is seems like the best direction we could go.
We are dropping a bundler and going for pure TS compilation getting errors more streamlined (accurate) and consistent import behavior.

@vmasek
vmasek merged commit 9099514 into mainDec 9, 2024
@vmasek
vmasek deleted the nx-19-update branch December 9, 2024 13:19
@matejchalkmatejchalk mentioned this pull request Nov 14, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BioPhotonBioPhotonBioPhoton approved these changes
@matejchalkmatejchalkmatejchalk approved these changes

Assignees

@vmasekvmasek

Labels

🧩 ci🧩 cli🧩 core🧩 coverage-plugin🧩 create-cli🧩 eslint-plugin🧩 js-packages-pluginPlugin for audit and outdated dependencies🧩 lighthouse-plugin🧩 models🌊 NxNx related issues🧩 nx-plugin📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests🛠️ tooling🧩 utils

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't bundle build output reduce dependencies ci: migrate to Nx 19

3 participants

@vmasek@BioPhoton@matejchalk