Skip to content

fix(ci): always show execute process errors and log stdout if verbose - #952

Merged
vmasek merged 1 commit into
mainfrom
ci-package-logging
Mar 4, 2025
Merged

fix(ci): always show execute process errors and log stdout if verbose#952
vmasek merged 1 commit into
mainfrom
ci-package-logging

Conversation

@vmasek

@vmasekvmasek commented Mar 4, 2025

Copy link
Copy Markdown
Collaborator

part of #888

@vmasek
vmasek requested a review from matejchalkMarch 4, 2025 00:02
@github-actionsgithub-actionsBot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 ci labels Mar 4, 2025
@vmasek
vmasekforce-pushed the ci-package-logging branch from aeb6260 to cd57415CompareMarch 4, 2025 00:03
@vmasekvmasek mentioned this pull request Mar 4, 2025
13 tasks
@vmasek
vmasekforce-pushed the ci-package-logging branch from cd57415 to dae48baCompareMarch 4, 2025 00:26
@github-actions

github-actionsBot commented Mar 4, 2025

Copy link
Copy Markdown
Contributor

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit c888da5 with previous commit ebb4ed5.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Categories

🏷️ Category⭐ Previous score⭐ Current score🔄 Score change
Performance🟡 52🔴 45↓ −7.7
Code coverage🟢 91🟢 91↑ +0.1
Documentation🔴 23🔴 23↓ −0.1
Security🟡 75🟡 75
Updates🟡 77🟡 77
Accessibility🟢 92🟢 92
Best Practices🟢 100🟢 100
SEO🟡 61🟡 61
Bug prevention🟢 100🟢 100
Code style🟢 100🟢 100
👍 1 group improved, 👎 2 groups regressed, 👍 2 audits improved, 👎 7 audits regressed, 11 audits changed without impacting score

🗃️ Groups

🔌 Plugin🗃️ Group⭐ Previous score⭐ Current score🔄 Score change
LighthousePerformance🟡 52🔴 45↓ −7.7
Code coverageCode coverage metrics🟢 91🟢 91↑ +0.1
JSDoc coverageDocumentation coverage🔴 23🔴 23↓ −0.1

15 other groups are unchanged.

🛡️ Audits

🔌 Plugin🛡️ Audit📏 Previous value📏 Current value🔄 Value change
LighthouseSpeed Index🟨 5.1 s🟥 8.1 s↑ +59.1 %
LighthouseFirst Contentful Paint🟨 2.8 s🟥 3.2 s↑ +12.3 %
LighthouseTime to Interactive🟥 13.3 s🟥 16.2 s↑ +21.9 %
LighthouseLargest Contentful Paint🟨 3.7 s🟨 3.9 s↑ +5.3 %
LighthouseTotal Blocking Time🟥 2,620 ms🟥 7,150 ms↑ +173.4 %
Code coverageFunction coverage🟩 92.8 %🟩 93 %↑ +0.2 %
Code coverageBranch coverage🟨 86 %🟨 85.9 %↓ −0.1 %
JSDoc coverageFunctions coverage🟥 450 undocumented functions🟥 451 undocumented functions↑ +0.2 %
Code coverageLine coverage🟨 89.9 %🟨 89.9 %↑ +0.1 %
LighthouseMinimizes main-thread work🟥 11.9 s🟥 20.0 s↑ +68.3 %
LighthouseAvoids enormous network payloads🟩 Total size was 1,832 KiB🟩 Total size was 1,835 KiB↑ +0.2 %
LighthouseJavaScript execution time🟥 5.8 s🟥 9.1 s↑ +57.1 %
LighthouseMetrics🟩 100%🟩 100%↑ +21.9 %
LighthouseMax Potential First Input Delay🟥 1,490 ms🟥 2,560 ms↑ +71.8 %
LighthouseReduce unused CSS🟥 Potential savings of 54 KiB🟥 Potential savings of 67 KiB↑ +53.3 %
LighthouseServer Backend Latencies🟩 90 ms🟩 190 ms↑ +109 %
LighthouseUses efficient cache policy on static assets🟨 27 resources found🟨 27 resources found↑ +0.1 %
LighthouseNetwork Round Trip Times🟩 20 ms🟩 100 ms↑ +296.5 %
LighthouseInitial server response time was short🟩 Root document took 470 ms🟩 Root document took 410 ms↓ −13.1 %
LighthouseEliminate render-blocking resources🟥 Potential savings of 790 ms🟥 Potential savings of 790 ms↓ −0.6 %

576 other audits are unchanged.

Comment threadpackages/ci/src/lib/cli/commands/compare.ts Outdated
Comment threadpackages/ci/src/lib/monorepo/list-projects.ts Outdated
Comment threadpackages/ci/src/lib/run.integration.test.ts Outdated
@vmasek
vmasekforce-pushed the ci-package-logging branch from dae48ba to 8cb7f69CompareMarch 4, 2025 11:23
@vmasek
vmasek enabled auto-merge (rebase) March 4, 2025 11:23

@matejchalkmatejchalk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vmasek
vmasek merged commit b41de47 into mainMar 4, 2025
@vmasek
vmasek deleted the ci-package-logging branch March 4, 2025 11:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧩 ci📖 Project documentationimprovements or additions to the project documentation🔬 testingwriting tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@vmasek@matejchalk