Uh oh!
There was an error while loading. Please reload this page.
[pull] main from jsr-io:main - #128
Merged
Merged
Conversation
…ecting (#1538) Since #1473, docs are only served for the latest version of a package. The package overview route also requests docs, so visiting `/@scope/pkg@version` for any non-latest version got `docsOnlyForLatestVersion` from the API and 302'd to `/@scope/pkg/doc/all_symbols` — making version pages unreachable from the Versions tab. Now only the actual doc routes (entrypoint/symbol/all_symbols) redirect to the latest version's docs; the package overview page fetches the version's metadata and renders the header and nav for that version, with a note that documentation is only available for the latest version. This also fixes the `TypeError: b.subitems is not iterable` crash in the local symbol search island reported in the issue: since #1518, module docs can contain an `example` section, but the island cast every section to `namespace_section` and iterated `symbol.subitems`. Sections other than `namespace_section` are now skipped when building the search index and when filtering results. Fixes#1537
The `docker-images` job takes ~12 minutes on every merge queue run because its Docker layer cache never hits: GHA caches are branch-scoped, and `merge_group` runs execute on transient `gh-readonly-queue/...` refs, so the cache written there is deleted along with the ref and is never readable by later runs. The only runs that could write a cache readable by everyone (pushes to `main`) skip the build entirely due to the image-reuse optimization — there are currently zero caches on `refs/heads/main`. As a result every merge queue run pays ~7:20 compiling all dependencies from scratch, plus ~2:30 exporting a ~1.4GB GHA cache into a black hole. That garbage has also pushed the repo past the 10GB Actions cache quota (11GB currently), evicting the useful `rust-cache` entries for the `check`/`test` jobs. This switches the build cache to a registry cache stored as a `:buildcache` tag next to the images in Artifact Registry, which is shared across all refs. `image-manifest=true,oci-mediatypes=true` is required for Artifact Registry to accept the cache manifest. No new permissions are needed — the job already pushes image tags to the same registry path. Expected impact: after the first (still cold) run seeds the cache, `docker-images` should drop from ~12 min to ~3–4 min whenever `Cargo.lock`/`Cargo.toml` are unchanged, shortening the merge queue's critical path since `staging` waits on this job.
Fixes#155Fixes#615Fixes#886Fixes#1179Fixes#1258Fixes#1478 Upgrades deno_graph 0.110.2 → 0.111.0 and deno_doc 0.206.0 → 0.207.0, picking up the slow-types / d.ts generation fixes from denoland/deno_graph#667 and the docs-side type inference fix from denoland/deno_doc#852: - **#615**: object properties referencing functions get `typeof fn` in the generated d.ts instead of an untyped (implicit `any`) property. - **#886 / #1179**: `[Symbol.iterator]`, `[Symbol.dispose]` and other well-known symbol class members are no longer dropped from the generated d.ts. - **#1258**: spread elements in `as const` arrays are no longer silently dropped from the emitted tuple type (d.ts side, deno_graph) and no longer render as `any[]` on doc pages (docs side, deno_doc). Negative number literals in tuples are also fixed. - **#155**: `Object.freeze(... as const satisfies ...)` and `new`-expressions of non-generic module-level classes no longer error with missing-explicit-type. Note these fixes apply at publish time — already-published versions keep the d.ts/docs generated when they were published. Also: deno_graph 0.111.0 removed the `unstable_text_imports` build option (text imports are now always enabled in graph building), so the three `BuildOptions` sites that passed `false` just drop the field. deno_doc 0.206.0 → 0.207.0 touches only type inference (`src/ts_type.rs`) — no `.hbs` template or ctx struct changes, so no frontend JSX mirroring is needed. `cargo test npm::` (tarball specs) passes unchanged; clippy clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )