Skip to content

Cmd results - #13

Merged
antazoey merged 20 commits into
masterfrom
CmdResults
Jun 30, 2020
Merged

Cmd results#13
antazoey merged 20 commits into
masterfrom
CmdResults

Conversation

@antazoey

@antazoeyantazoey commented Jun 29, 2020•
edited
Loading

Copy link
Copy Markdown

This is the new way we are supposed to return stuff from Commands. The old way is deprecated and I was asked to change it. There are no changes in usage.

Also squeezes in some missing changelog entries (the only breaking changes). Which by the way could cause problems for us.

@alanag13

alanag13 commented Jun 29, 2020

Copy link
Copy Markdown

can you an alias an output? i this breaking is going to cause us problems, I'd rather just point the old to the new.

@antazoey

antazoey commented Jun 29, 2020

Copy link
Copy Markdown
Author

@alanag13 You were right, this is what they want.

kiran-chaudhary
kiran-chaudhary reviewed Jun 30, 2020
View reviewed changes
Comment threadPacks/Code42/Integrations/Code42/Code42.py Outdated
kiran-chaudhary
kiran-chaudhary reviewed Jun 30, 2020
View reviewed changes
Comment threadPacks/Code42/Integrations/Code42/Code42.py Outdated
antazoey
antazoey commented Jun 30, 2020
View reviewed changes
Comment threadPacks/Code42/Integrations/Code42/Code42.py
file_results = CommandResults(
outputs_prefix="File", outputs_key_field=None, outputs=file_context
)
return code42_results, file_results

@antazoeyantazoeyJun 30, 2020•
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiran-chaudhary The way it is set up, these commands are allowed to return 1 or more CommandResults objects. This command is the only one that returns more than one. The reason for this is because they have different outputs_prefix properties, which is important when digging through Incident Context looking at the Outputs - and mapping outputs to different things, etc. Our integration modifies the system "File" outputs (line 744) as well as our own custom-defined Code42 outputs.

@kiran-chaudharykiran-chaudharyJun 30, 2020

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

kiran-chaudhary
kiran-chaudhary approved these changes Jun 30, 2020
View reviewed changes

@kiran-chaudharykiran-chaudhary left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antazoey
antazoey merged commit fb18ea4 into masterJun 30, 2020
@antazoey
antazoey deleted the CmdResults branch June 30, 2020 13:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@timabrmsntimabrmsnAwaiting requested review from timabrmsn
2 more reviewers
@kiran-chaudharykiran-chaudharykiran-chaudhary approved these changes
@alanag13alanag13alanag13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antazoey@alanag13@kiran-chaudhary