Skip to content

New Beginner and Advanced Practice and Solutions - #22

Merged
phrdang merged 33 commits into
code4tomorrow:masterfrom
armeetj:master
Mar 23, 2021
Merged

New Beginner and Advanced Practice and Solutions#22
phrdang merged 33 commits into
code4tomorrow:masterfrom
armeetj:master

Conversation

@armeetj

Copy link
Copy Markdown
Contributor

Changes

I realized the lack of enough practice problems in certain chapters, so I created numerous comprehensive practice problems with respective solutions.

Beginner

Chapter 1 Changes

  • new HelloWorld practice and solution: practice std output
  • new Comments practice and solution: practice writing single and multi-line comments

Chapter 2 Changes

  • new ApplesOranges practice and solution: learn to concatenate and process Strings/variables
  • new VariableTypes practice and solution: learn to define variables of different datatypes

Chapter 4 Changes

  • new CarDealership practice and solution: learn to use expressions to store values in variables

Advanced

Chapter 16 Changes

  • new LinkedList practice and solution: learn to use multiple classes and OOP to implement a Linked List

TODO:

  • advanced: add new exercises for Stack, Queue, Bag implementations
  • beginners: possibly more exercises with String formatting

@armeetj

Copy link
Copy Markdown
ContributorAuthor

There seems to be an error in merging to the master branch.
Could someone please look into this?

My forked repo: https://github.com/ArmeetJatyani/java

@phrdangphrdang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the practice problems Armeet! I left comments and suggestions on some files, if you could take a look that'd be great.

Comment thread.gitignore Outdated
Comment threadsrc/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java Outdated
Comment threadsrc/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java Outdated
Comment threadsrc/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java Outdated
Comment threadsrc/com/codefortomorrow/beginner/chapter2/practice/VariableTypes.java Outdated
Comment threadsrc/com/codefortomorrow/beginner/chapter2/solutions/ApplesOranges.java Outdated
Comment threadsrc/com/codefortomorrow/beginner/chapter2/solutions/ApplesOranges.java Outdated
Comment threadsrc/com/codefortomorrow/beginner/chapter2/solutions/VariableTypes.java Outdated
armeetjand others added 14 commits March 15, 2021 17:14
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…es.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…ges.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…ges.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…pes.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
….java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…t.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
@armeetj

Copy link
Copy Markdown
ContributorAuthor

@phrdang all requested changes have been addressed, and the latest version has been pushed

armeetjand others added 3 commits March 15, 2021 17:26
…java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…es.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>
…es.java
Co-authored-by: Rebecca Dang <35876322+phrdang@users.noreply.github.com>

@armeetjarmeetj left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, changes made.

@armeetj
armeetj requested a review from phrdangMarch 16, 2021 07:51

@phrdangphrdang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just had one more question (see the LinkedList.java solution).

Comment threadsrc/com/codefortomorrow/advanced/chapter16/solutions/LinkedList.java Outdated

@armeetjarmeetj left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phrdang I don't see any comments anywhere. Is it ready for approval?

@phrdang

Copy link
Copy Markdown
Member

@phrdang I don't see any comments anywhere. Is it ready for approval?

Whoops I think it was accidentally resolved. Here's a screenshot:

Screen Shot 2021-03-17 at 11 22 02 AM

@armeetj

Copy link
Copy Markdown
ContributorAuthor

@phrdang I don't see any comments anywhere. Is it ready for approval?

Whoops I think it was accidentally resolved. Here's a screenshot:

Screen Shot 2021-03-17 at 11 22 02 AM

Alright, I'm on it!

Comment threadsrc/com/codefortomorrow/beginner/chapter2/solutions/VariableTypes.java Outdated
@armeetj
armeetj requested a review from phrdangMarch 22, 2021 18:10

@armeetjarmeetj left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed UUID usage, and removed "bad practices."

Comment threadsrc/com/codefortomorrow/beginner/chapter1/solutions/HelloWorld.java Outdated

@JJ27JJ27 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two comments but they were really small things. Just fix those and you should be good to go :)

….java
Co-authored-by: JJ27 <66833672+JJ27@users.noreply.github.com>

@phrdangphrdang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your submissions! Looks good to me :)

@phrdang

phrdang commented Mar 23, 2021

Copy link
Copy Markdown
Member

Also @ArmeetJatyani I wanted to note that these changes will be implemented in the curriculum during the summer session since we're currently in the process of transferring our curriculum from Thinkific to another platform. I will merge your PR now though.

@phrdang
phrdang merged commit 1a9bd2f into code4tomorrow:masterMar 23, 2021
@armeetj

Copy link
Copy Markdown
ContributorAuthor

Thanks! Sounds great!

@phrdang

Copy link
Copy Markdown
Member

Update: Added stuff to Notion (the actual curriculum)

  • Ch. 1.1: HelloWorld, Comments
  • Ch. 2.1: ApplesOranges, VariableTypes (see Fix VariableTypes solution errors #27 )
  • Ch. 4.5: CarDealership (it was already on Notion, but I just updated the instructions)

TODO

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@armeetj@phrdang@JJ27@abidaJustice