feat: make missing ratio warning threshold configurable - #9
Merged
Conversation
codeMaestro78
commented
Jan 20, 2026
Owner
- Add MISSING_RATIO_WARNING_THRESHOLD constant (default 0.5)
- Add missing_ratio_warning_threshold parameter to DataAnalyzer constructor
- Replace magic number 0.5 with configurable parameter
- Make warning message dynamic to show actual threshold percentage
- Fix linting issues: line length, variable naming, and formatting
- Add MISSING_RATIO_WARNING_THRESHOLD constant (default 0.5) - Add missing_ratio_warning_threshold parameter to DataAnalyzer constructor - Replace magic number 0.5 with configurable parameter - Make warning message dynamic to show actual threshold percentage - Fix linting issues: line length, variable naming, and formatting
The latest updates on your projects. Learn more about Vercel for GitHub.
|
>> >> - Add MISSING_RATIO_WARNING_THRESHOLD constant (default 0.5) >> - Add missing_ratio_warning_threshold parameter to DataAnalyzer constructor >> - Replace magic number 0.5 with configurable parameter >> - Make warning message dynamic to show actual threshold percentage >> - Fix linting issues: line length, variable naming, and formatting
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a configurable threshold for missing ratio warnings while also introducing several other changes that extend beyond the stated scope. The main feature allows users to customize when warnings are generated for columns with high missing value ratios (default 50%).
Changes:
- Added configurable missing_ratio_warning_threshold parameter to DataAnalyzer constructor
- Added comprehensive input validation for the analyze() method
- Changed class_distribution structure from dict to list format (breaking API change)
- Enhanced docstrings for multiple methods
- Modified categorical type inference logic for numeric columns
- Simplified null/NaN detection using pandas.isna()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
codeMaestro78
commented
Jan 20, 2026
OwnerAuthor
The issue has been resolved. |
- Document that class_distribution is a list of dicts with label/count/ratio keys - Address API consistency concerns by clearly specifying the data structure - No functional changes, only documentation improvement
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.