Uh oh!
There was an error while loading. Please reload this page.
feat: make errors spanned in computations - #1
Conversation
| body: Box::new(body), | ||
| }) | ||
| Sym::Lambda(prog) => non_linear_check( | ||
| prog.iter().map(|s| &s.value).positioned( |
There was a problem hiding this comment.
I think we should avoid such "on the fly" computation of default positions and provide another representation of programs that includes position information instead @SolarLiner
There was a problem hiding this comment.
You mean baking positions into ComputationTree? I don't think it is necessary to duplicate data structures here; otherwise yes, keeping positions around would be best.
There was a problem hiding this comment.
Yup. In that case let's just add a field for the positions in the ComputationTree
There was a problem hiding this comment.
We can use the Spanned wrapper type that has all the goodies to make manipulating positions and values easier within it
No description provided.