Fully qualify references to generated interfaces by simonmckenzie · Pull Request #89 · codecentric/net_automatic_interface

simonmckenzie · 2025-09-03T04:51:44Z

This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. See #87.

The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names where a single unambiguous match can be made between the symbol and the list of interfaces being generated.

For the example provided in #87, the code will now generate this output:

//--------------------------------------------------------------------------------------------------// <auto-generated>// This code was generated by a tool.//// Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.// </auto-generated>//--------------------------------------------------------------------------------------------------namespaceTest{[global::System.CodeDom.Compiler.GeneratedCode("AutomaticInterface","")]publicpartialinterfaceITest1{/// <inheritdoc cref="Test.Test1.Get(ITest2)" />voidGet(global::Test.Tests.ITest2test);}}//--------------------------------------------------------------------------------------------------// <auto-generated>// This code was generated by a tool.//// Changes to this file may cause incorrect behavior and will be lost if the code is regenerated.// </auto-generated>//--------------------------------------------------------------------------------------------------namespaceTest.Tests{[global::System.CodeDom.Compiler.GeneratedCode("AutomaticInterface","")]publicpartialinterfaceITest2{}}

simonmckenzie · 2025-10-22T08:49:11Z

This is ready for review again - I just had a last minute refactoring idea :)

ChristianSauer · 2025-11-04T12:36:59Z

Could you be so kind and merge master into this? Than I will merge it as 6.x I think because it's potentially breaking

simonmckenzie · 2025-11-05T03:31:54Z

Not a problem @ChristianSauer. I hope to get this done next week.

simonmckenzie · 2025-11-12T01:40:57Z

Hi @ChristianSauer,

I've rebased the branch on master, but happy to get the other PR merged first, then I can rebase and refactor again, as I think I should probably move the other PR's changes into the RoslynExtensions class. Whatever suits you, of course :)

ChristianSauer · 2025-11-13T10:42:30Z

@simonmckenzie I merged the other PR first :)

This addresses an issue where, when a class references a generated interface, those references are not fully qualified, resulting in an interface that doesn't compile. The change is to precalculate the list of interface names that will be generated, and, during symbol string generation, replace unrecognised symbols with generated names _where a single unambiguous match can be made between the symbol and the list of interfaces being generated_.

- Change approach to use `ToDisplayParts`, which removes the need for regex parsing of generated code - Fix bug in `ReplaceWithInferredInterfaceName` where dots weren't being escaped - Add tests to ensure partially qualified references will be resolved correctly

…class; refactor This centralises the rendering logic plus simplifies the implementation to use `ITypeSymbol.WithNullableAnnotation` and hands the rendering off to the default `ToDisplayString` implementation

simonmckenzie · 2025-11-18T23:19:18Z

Hi @ChristianSauer,

I've rebased again and refactored the changes from #85 into the RoslynExtensions (9148e56).

ChristianSauer · 2026-04-23T08:17:39Z

Closing due to: #93