Skip to content

feat(cli): print failed hooks - #4476

Merged
kobenguyent merged 5 commits into
3.xfrom
4466-error-handling-suggestion-for-aftersuite-hook
Sep 17, 2024
Merged

feat(cli): print failed hooks#4476
kobenguyent merged 5 commits into
3.xfrom
4466-error-handling-suggestion-for-aftersuite-hook

Conversation

@kobenguyent

@kobenguyentkobenguyent commented Sep 2, 2024

Copy link
Copy Markdown
Collaborator

Motivation/Description of the PR

run command
Screenshot 2024-09-02 at 15 25 20

run workers command
Screenshot 2024-09-02 at 15 24 53

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyentkobenguyent linked an issue Sep 2, 2024 that may be closed by this pull request
Error handling suggestion for AfterSuite Hook #4466
Closed
@kobenguyent

kobenguyent commented Sep 3, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Successfully published 3.6.6-beta.5

@kobenguyent
kobenguyent merged commit d031ad0 into 3.xSep 17, 2024
@kobenguyent
kobenguyent deleted the 4466-error-handling-suggestion-for-aftersuite-hook branch September 17, 2024 13:51
@kobenguyentkobenguyent mentioned this pull request Sep 17, 2024
Merged
@mirao

mirao commented Dec 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

@kobenguyent
I have suspicion that this bug fix caused that if there are failed scenarios and also failed hooks, then the failed scenarios aren't reported in total count of failures 🐛

E.g.
Here 36 failures should be reported (because 36 scenarios failed), but we are getting this (Mochawesome HTML report)

image

[1.dev:chromium] FAIL | 191 passed, 4 failedHooks, 44 skipped // 2h

Tested with CodeceptJS 3.6.7

@miraomirao mentioned this pull request Dec 11, 2024
Closed
kobenguyent
kobenguyent commented Dec 11, 2024
View reviewed changes
Comment threadlib/cli.js

this.failures.forEach((failure) => {
if (failure.constructor.name === 'Hook') {
stats.failures -= stats.failures

@kobenguyentkobenguyentDec 11, 2024

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @mirao perhaps the failure count should not be touched, just adding failedHooks is good enough. What do you think?

@miraomiraoDec 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it makes sense.

@miraomiraoDec 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stats.failures -= stats.failures isn't the same as stats.failures = 0 ?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavertMikDavertMikAwaiting requested review from DavertMik
1 more reviewer
@miraomiraomirao left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cli

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error handling suggestion for AfterSuite Hook

2 participants

@kobenguyent@mirao