Uh oh!
There was an error while loading. Please reload this page.
Fix issue with docker build - #4980
Merged
kobenguyent merged 3 commits intoMay 6, 2025
Merged
Conversation
thomashohn
commented
Apr 28, 2025
ContributorAuthor
@kobenguyent This PR seems to fix the build issue in #4975 - but something is no longer working in one of the tests |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the docker build process by updating the repository’s GitHub workflow files to allow for release info changes during package updates. The key changes include:
- Adding a step to update apt-get with the --allow-releaseinfo-change flag in plugin.yml, playwright.yml, and acceptance-tests.yml.
- Adjusting the quoting style for the PHP server run command in plugin.yml.
- Introducing an additional update command in acceptance-tests.yml that may be redundant.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/plugin.yml | Added apt-get update with --allow-releaseinfo-change and adjusted quoting. |
| .github/workflows/playwright.yml | Added apt-get update with --allow-releaseinfo-change step. |
| .github/workflows/acceptance-tests.yml | Added apt-get update with --allow-releaseinfo-change, resulting in consecutive update commands. |
Files not reviewed (1)
- Dockerfile: Language not supported
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)