Skip to content

Add safeguards fo finish in pause.js #5461 - #5507

Closed
incoming-th wants to merge 151 commits into
codeceptjs:4.xfrom
incoming-th:3.x
Closed

Add safeguards fo finish in pause.js #5461#5507
incoming-th wants to merge 151 commits into
codeceptjs:4.xfrom
incoming-th:3.x

Conversation

@incoming-th

@incoming-thincoming-th commented Apr 7, 2026

Copy link
Copy Markdown
Contributor

Motivation/Description of the PR

Error processing test.finish event: TypeError: finish is not a function

Applicable helpers:

  • Playwright
  • Puppeteer
  • WebDriver
  • REST
  • FileHelper
  • Appium
  • TestCafe

Applicable plugins:

  • allure
  • autoDelay
  • autoLogin
  • customLocator
  • pauseOnFail
  • coverage
  • retryFailedStep
  • screenshotOnFail
  • selenoid
  • stepByStepReport
  • stepTimeout
  • wdio
  • subtitles

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 🧹 Chore
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)
image

dependabotBotand others added 30 commits July 16, 2025 09:36
@dependabot
chore(deps-dev): bump playwright from 1.53.0 to 1.54.1 (codeceptjs#5043)
c8d933f
Bumps [playwright](https://github.com/microsoft/playwright) from 1.53.0 to 1.54.1.
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.53.0...v1.54.1)
---
updated-dependencies:
- dependency-name: playwright
dependency-version: 1.54.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @eslint/js from 9.30.0 to 9.31.0 (codeceptjs#5044)
4ef395f
---
updated-dependencies:
- dependency-name: "@eslint/js"
dependency-version: 9.31.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump expect from 29.7.0 to 30.0.4 (codeceptjs#5036)
7c764fc
Bumps [expect](https://github.com/jestjs/jest/tree/HEAD/packages/expect) from 29.7.0 to 30.0.4.
- [Release notes](https://github.com/jestjs/jest/releases)
- [Changelog](https://github.com/jestjs/jest/blob/main/CHANGELOG.md)
- [Commits](https://github.com/jestjs/jest/commits/v30.0.4/packages/expect)
---
updated-dependencies:
- dependency-name: expect
dependency-version: 30.0.4
dependency-type: direct:development
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump graphql from 16.10.0 to 16.11.0 (codeceptjs#5049)
6b45b27
Bumps [graphql](https://github.com/graphql/graphql-js) from 16.10.0 to 16.11.0.
- [Release notes](https://github.com/graphql/graphql-js/releases)
- [Commits](graphql/graphql-js@v16.10.0...v16.11.0)
---
updated-dependencies:
- dependency-name: graphql
dependency-version: 16.11.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump electron from 37.1.0 to 37.2.3 (codeceptjs#5047)
a130ba3
Bumps [electron](https://github.com/electron/electron) from 37.1.0 to 37.2.3.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v37.1.0...v37.2.3)
---
updated-dependencies:
- dependency-name: electron
dependency-version: 37.2.3
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump puppeteer from 24.8.0 to 24.15.0 (codeceptjs#5054)
2aef872
@dependabot
chore(deps): bump axios from 1.8.4 to 1.11.0 (codeceptjs#5055)
af27fc9
Bumps [axios](https://github.com/axios/axios) from 1.8.4 to 1.11.0.
- [Release notes](https://github.com/axios/axios/releases)
- [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md)
- [Commits](axios/axios@v1.8.4...v1.11.0)
---
updated-dependencies:
- dependency-name: axios
dependency-version: 1.11.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump typedoc-plugin-markdown from 4.7.0 to 4.7.1 (co…
2ad213a
…deceptjs#5046)
Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.7.0 to 4.7.1.
- [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases)
- [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md)
- [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/typedoc-plugin-markdown@4.7.1/packages/typedoc-plugin-markdown)
---
updated-dependencies:
- dependency-name: typedoc-plugin-markdown
dependency-version: 4.7.1
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps): bump browser-actions/setup-chrome from 1 to 2 (codeceptj…
4cc3c84
…s#5041)
Bumps [browser-actions/setup-chrome](https://github.com/browser-actions/setup-chrome) from 1 to 2.
- [Release notes](https://github.com/browser-actions/setup-chrome/releases)
- [Changelog](https://github.com/browser-actions/setup-chrome/blob/master/CHANGELOG.md)
- [Commits](browser-actions/setup-chrome@v1...v2)
---
updated-dependencies:
- dependency-name: browser-actions/setup-chrome
dependency-version: '2'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump expect from 30.0.4 to 30.0.5 (codeceptjs#5064)
e090eb9
@kobenguyent
fix: 5070 issue (codeceptjs#5071)
220b73f
@dependabot
chore(deps-dev): bump typedoc from 0.28.7 to 0.28.10 (codeceptjs#5059)
5c14df4
Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.28.7 to 0.28.10.
- [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
- [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
- [Commits](TypeStrong/typedoc@v0.28.7...v0.28.10)
---
updated-dependencies:
- dependency-name: typedoc
dependency-version: 0.28.10
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kobenguyent
fix: hook exit code (codeceptjs#5058)
a27b99e
* fix: hook exit code
* Update asyncWrapper.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update asyncWrapper.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update asyncWrapper.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update asyncWrapper.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Update asyncWrapper.js
* Update asyncWrapper.js
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kobenguyent
5066 unable to inject data between workers because of proxy object (c…
3cf5fe2
…odeceptjs#5072)
* fix share workers
* fix share workers
@dependabot
chore(deps): bump actions/checkout from 4 to 5 (codeceptjs#5062)
5476a9d
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v5)
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-version: '5'
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump tsd from 0.32.0 to 0.33.0 (codeceptjs#5063)
3408489
Bumps [tsd](https://github.com/tsdjs/tsd) from 0.32.0 to 0.33.0.
- [Release notes](https://github.com/tsdjs/tsd/releases)
- [Commits](tsdjs/tsd@v0.32.0...v0.33.0)
---
updated-dependencies:
- dependency-name: tsd
dependency-version: 0.33.0
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump typedoc-plugin-markdown from 4.7.1 to 4.8.1 (co…
eceb2a3
…deceptjs#5067)
Bumps [typedoc-plugin-markdown](https://github.com/typedoc2md/typedoc-plugin-markdown/tree/HEAD/packages/typedoc-plugin-markdown) from 4.7.1 to 4.8.1.
- [Release notes](https://github.com/typedoc2md/typedoc-plugin-markdown/releases)
- [Changelog](https://github.com/typedoc2md/typedoc-plugin-markdown/blob/main/packages/typedoc-plugin-markdown/CHANGELOG.md)
- [Commits](https://github.com/typedoc2md/typedoc-plugin-markdown/commits/typedoc-plugin-markdown@4.8.1/packages/typedoc-plugin-markdown)
---
updated-dependencies:
- dependency-name: typedoc-plugin-markdown
dependency-version: 4.8.1
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@NivYarmus
feat: shuffle test suite order in run command (codeceptjs#5051)
4daabc8
@kobenguyent
fix: sessions playwright traces - naming convention and error handling (
ff63f70
codeceptjs#5073)
@kobenguyent
release 3.7.4 (codeceptjs#5075)
a483106
* release 3.7.4
@kobenguyent
update docs
2e4d0bb
@kobenguyent
fix: Update inquirer (codeceptjs#5076)
376c758
@kobenguyent
add docs
f0759ca
@kobenguyent
feat(cli): make test file hyperlink (codeceptjs#5078)
04ec768
@kobenguyent
Playwright: I.waitForText() causes unexpected delay equal to `waitFor…
e3a195d
…Timeout` value at the end of test suite (codeceptjs#5077)
* Initial plan
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
@kobenguyent
3.7.3 I.seeResponseContainsJson not working (codeceptjs#5081)
93ab75d
* Initial plan
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
@kobenguyent
Fix JUnit XML test case name inconsistency when using scenario retries (
58f83a1
codeceptjs#5082)
* Initial plan
* Fix JUnit XML test case name inconsistency in scenario retries
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Improve edge case handling for empty suite titles in cloned tests
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
@kobenguyent
fix: testcafe workflow failed (codeceptjs#5085)
f295302
* fix: TestCafe_test.js
* Fix TestCafe form submission timeout with efficient polling mechanism (codeceptjs#5080)
* Initial plan
* Fix failed TestCafe tests by skipping doubleClick test
* Update testcafe.yml
* Update testcafe.yml
* Update TestCafe_test.js
* Update TestCafe_test.js
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Fix TestCafe form submission timeout in CI environments
* Improve TestCafe form submission timeout handling with polling mechanism
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Improve TestCafe form submission timeout with efficient polling mechanism
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Update testcafe.yml
* fix: Chrome popup causes problems with TestCafe
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Co-authored-by: kobenguyent <kobenguyent@gmail.com>
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
@kobenguyent
[FR] - Support feature.only like Scenario.only (codeceptjs#5087)
ce16e92
* Initial plan
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Add TypeScript types for Feature.only method
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Fix TypeScript test expectations for hook return types
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
@kobenguyent
Fix tryTo steps appearing in test failure traces (codeceptjs#5088)
2047cf2
* Initial plan
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
* Changes before error encountered
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
@kobenguyent
kobenguyent changed the base branch from 3.x to 4.xMay 26, 2026 03:27
@kobenguyent

kobenguyent commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

@incoming-th as of now the base branch is 4.x, could you help resolve this?

@incoming-th

incoming-th commented Jun 4, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@kobenguyent Happy to help but I am still on 3.7.x release. Is there any breaking change to 4.x that we should be aware of? I read the doc but not sure if we can safely just upgrade to 4.x

@kobenguyent

kobenguyent commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

@incoming-th maybe this helps https://codecept.io/blog/codeceptjs-4/

@incoming-th

incoming-th commented Jun 7, 2026

Copy link
Copy Markdown
ContributorAuthor

@kobenguyent#5612 So this one can be closed I guess?

@kobenguyent

kobenguyent commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

I suppose so @incoming-th thanks. 😊

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DavertMikDavertMikAwaiting requested review from DavertMik
@DenysKuchmaDenysKuchmaAwaiting requested review from DenysKuchma

Assignees

@incoming-thincoming-th

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error processing test.finish event: TypeError: finish is not a function

18 participants

@incoming-th@kobenguyent@NivYarmus@actions-user@mirao@myrepojuly@Samuel-StO@thomashohn@ngraf@mhassan1@danielrentz@epszaw@mikhail-yesipchuk-zenitech@mozillalives@ajamadar-mdsol@DenysKuchma@gimler