fix(playwright): replace constructor.name checks with stable public API (#5559)

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!

[mirao]

Summary

Fixes#5559.

Playwright 1.60 switched its distribution from individual compiled files to a single esbuild bundle. esbuild prefixes class names with _ to avoid naming conflicts, so Locator silently became _Locator and FrameLocator likely _FrameLocator. This broke all constructor.name checks in Playwright.js.

Three fixes, all replacing fragile constructor.name checks with duck-typing on stable public-API methods:

Context type	url()	innerText()	Correct branch
Page	✓	✓	locator('body').innerText()
Frame	✓	✓	locator('body').innerText()
FrameLocator	✗	✗	locator('body').innerText()
Locator	✗	✓	el.innerText()

• proceedSee: el.constructor.name !== 'Locator' → typeof el.url !== 'function' && typeof el.innerText === 'function' (the main bug — caused within() + I.see() to time out)
• executeScript: constructor.name === 'FrameLocator' → typeof el.url !== 'function' && typeof el.innerText !== 'function'
• _getContext: (this.context && constructor.name === 'FrameLocator') || this.context → this.context (the FrameLocator sub-check was logically redundant)

Test plan

• Added a new unit test: within on css locator should use locator scope in see without explicit context — calls I.see() with no context arg while this.context is a Playwright Locator (the exact path that timed out)
• Verified without the fix + Playwright 1.60: test fails with locator.innerText: Timeout exceeded — waiting for locator('#register').first().locator('body')
• Verified with the fix + Playwright 1.60: 24/24 within tests pass
• Verified with the fix + Playwright 1.59: 24/24 within tests pass (fully backward-compatible)

🤖 Generated with Claude Code

[DavertMik]

Thank you! Just foud failing tests on this!