Skip to content

Change esprima link in dependency - #145

Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom
tahmidshahriar:master
Closed

Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom
tahmidshahriar:master

Conversation

@tahmidshahriar

@tahmidshahriartahmidshahriar commented Jun 23, 2015

Copy link
Copy Markdown

To fix this issue (in CodeCombat):

codecombat/codecombat#2853

@tahmidshahriar

tahmidshahriar commented Jun 23, 2015

Copy link
Copy Markdown
Author

I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)

@tahmidshahriar

tahmidshahriar commented Jun 23, 2015

Copy link
Copy Markdown
Author

One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.

Error :
image

@tahmidshahriar

tahmidshahriar commented Jun 29, 2015

Copy link
Copy Markdown
Author

This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.

@nwinter

nwinter commented Jun 29, 2015

Copy link
Copy Markdown
Contributor

Ah, that makes it easy.

Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.

@nwinternwinter mentioned this pull request Jun 29, 2015
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Change esprima link in dependency by tahmidshahriar · Pull Request #145 · codecombat/aether · GitHub
Skip to content
Change esprima link in dependency - #145
Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Closed
Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Conversation
@tahmidshahriar
@tahmidshahriartahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

To fix this issue (in CodeCombat):
codecombat/codecombat#2853
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error : 
image
@tahmidshahriar
tahmidshahriar
commented
Jun 29, 2015

Copy link


Copy Markdown

Author
This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.
@nwinter
nwinter
commented
Jun 29, 2015

Copy link


Copy Markdown

Contributor
Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.
@nwinternwinter
mentioned this pull request
Jun 29, 2015

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change esprima link in dependency by tahmidshahriar · Pull Request #145 · codecombat/aether · GitHub
Skip to content
Change esprima link in dependency - #145
Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Closed
Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Conversation
@tahmidshahriar
@tahmidshahriartahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

To fix this issue (in CodeCombat):
codecombat/codecombat#2853
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error : 
image
@tahmidshahriar
tahmidshahriar
commented
Jun 29, 2015

Copy link


Copy Markdown

Author
This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.
@nwinter
nwinter
commented
Jun 29, 2015

Copy link


Copy Markdown

Contributor
Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.
@nwinternwinter
mentioned this pull request
Jun 29, 2015

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change esprima link in dependency by tahmidshahriar · Pull Request #145 · codecombat/aether · GitHub
Skip to content
Change esprima link in dependency - #145
Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Closed
Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Conversation
@tahmidshahriar
@tahmidshahriartahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

To fix this issue (in CodeCombat):
codecombat/codecombat#2853
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error : 
image
@tahmidshahriar
tahmidshahriar
commented
Jun 29, 2015

Copy link


Copy Markdown

Author
This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.
@nwinter
nwinter
commented
Jun 29, 2015

Copy link


Copy Markdown

Contributor
Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.
@nwinternwinter
mentioned this pull request
Jun 29, 2015

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Change esprima link in dependency by tahmidshahriar · Pull Request #145 · codecombat/aether · GitHub
Skip to content
Change esprima link in dependency - #145
Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Closed
Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Conversation
@tahmidshahriar
@tahmidshahriartahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

To fix this issue (in CodeCombat):
codecombat/codecombat#2853
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error : 
image
@tahmidshahriar
tahmidshahriar
commented
Jun 29, 2015

Copy link


Copy Markdown

Author
This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.
@nwinter
nwinter
commented
Jun 29, 2015

Copy link


Copy Markdown

Contributor
Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.
@nwinternwinter
mentioned this pull request
Jun 29, 2015

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Change esprima link in dependency by tahmidshahriar · Pull Request #145 · codecombat/aether · GitHub
Skip to content
Change esprima link in dependency - #145
Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Closed
Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Conversation
@tahmidshahriar
@tahmidshahriartahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

To fix this issue (in CodeCombat):
codecombat/codecombat#2853
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error : 
image
@tahmidshahriar
tahmidshahriar
commented
Jun 29, 2015

Copy link


Copy Markdown

Author
This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.
@nwinter
nwinter
commented
Jun 29, 2015

Copy link


Copy Markdown

Contributor
Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.
@nwinternwinter
mentioned this pull request
Jun 29, 2015

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Change esprima link in dependency by tahmidshahriar · Pull Request #145 · codecombat/aether · GitHub
Skip to content
Change esprima link in dependency - #145
Closed
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Closed
Change esprima link in dependency#145
tahmidshahriar wants to merge 1 commit into
codecombat:masterfrom 
tahmidshahriar:master
Conversation
@tahmidshahriar
@tahmidshahriartahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

To fix this issue (in CodeCombat):
codecombat/codecombat#2853
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
I am not fully sure why the build failed with the only change being in dependency and the installation appears to be working fine. I would greatly appreciate any advice on how to fix this! :)
@tahmidshahriar
tahmidshahriar
commented
Jun 23, 2015

Copy link


Copy Markdown

Author
One of the reasons the tests might be failing might be because this downloads from a different branch. Initially, it was downloading from harmony branch. Recently, that branch had everything other than the main code removed from its branch and thus it no longer had scripts such as esparse.js which it needed to run. So, if I try to use the harmony branch, I get the enoent error. The change I made causes it to download from the master branch and that might be the reason the tests are failing.
 Error : 
image
@tahmidshahriar
tahmidshahriar
commented
Jun 29, 2015

Copy link


Copy Markdown

Author
This is no longer valid as ariya updated his branch and added the tools in bin, so the harmony branch should work once again.
@nwinter
nwinter
commented
Jun 29, 2015

Copy link


Copy Markdown

Contributor
Ah, that makes it easy.
Looks like we should be updating to the latest Esprima 2.x instead; that probably is going to be faster and work better than the old harmony branch. Just need to update to it and test everything to see if there have been any incompatible changes.
@nwinternwinter
mentioned this pull request
Jun 29, 2015

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tahmidshahriar@nwinter