Description
load_config() in src/config/loader.rs:222 accepts _cli_api_key: Option<&str> but completely ignores it. The CLI API key is only used later in build_llm_config(). The documented priority chain (CLI → env → config → global → defaults) does NOT apply to API keys during config loading.
Impact
Not a bug — build_llm_config() handles it correctly. But the parameter is misleading dead code.
Suggested Fix
Remove the parameter from load_config() or add a comment explaining why it's intentionally unused.
Description
load_config()insrc/config/loader.rs:222accepts_cli_api_key: Option<&str>but completely ignores it. The CLI API key is only used later inbuild_llm_config(). The documented priority chain (CLI → env → config → global → defaults) does NOT apply to API keys during config loading.Impact
Not a bug —
build_llm_config()handles it correctly. But the parameter is misleading dead code.Suggested Fix
Remove the parameter from
load_config()or add a comment explaining why it's intentionally unused.