Skip to content

🔧 Naive .gitignore parser misses edge cases #80

Description

@ajianaz

Description

The .gitignore parser in src/engine/scanner.rs:201-242 is a simplified reimplementation that doesn't handle:

  • ! negation patterns
  • ** double-star glob patterns correctly
  • [abc] character class patterns
  • Trailing spaces, comments after patterns, \ escaping

Suggested Fix

Use the ignore crate or git2::Repository::is_path_ignored() for accurate gitignore semantics.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions