Retry uploads on (connection) errors

[blueyed]

Example: https://ci.appveyor.com/project/pytestbot/pytest/build/1.0.5141/job/ycpyxb9yvrckho21#L402 (RemoteDisconnected)

codecov-bash tries 3 times already, sleeping for 30s inbetween.

[blueyed]

Another example:

 _____ _
 / ____| | |
 | | ___ __| | ___ ___ _____ __
 | | / _ \ / _ |/ _ \/ __/ _ \ \ / /
 | |___| (_) | (_| | __/ (_| (_) \ V /
 \_____\___/ \____|\___|\___\___/ \_/
 v2.0.15
==> Detecting CI provider
 AppVeyor Detected
 Fixing merge commit SHA
==> Preparing upload
 Error running `cd 'C:\projects\pytest' && git ls-files`: None
XX> Skip processing gcov
==> Collecting reports
XX> Searching for reports disabled
 Targeting specific files
 + coverage.xml bytes=1071184
==> Appending environment variables
 + TOXENV
==> Uploading
 .url https://codecov.io
 .query commit=3acfa3abdc7577f97bb40b9790c10d43c0e486e4&branch=master&job=pytestbot%2Fpytest%2F1.0.5975&pr=4409&service=appveyor&build=vku9wlsxtbjwwk0j&slug=pytest-dev%2Fpytest&flags=py27%2Cwindows&package=py2.0.15
 Pinging Codecov...
Error: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response',))
Tip: See all example repositories: https://github.com/codecov?query=example
Support channels:
 Email: hello@codecov.io
 IRC: #codecov
 Gitter: https://gitter.im/codecov/support
 Twitter: @codecov

[blueyed]

Any update on this?

Another example (from AppVeyor):

==> Uploading
 .url https://codecov.io
 .query commit=7e9f35e6cba84c386d29fc45e28d60b64927f753&branch=master&job=pytestbot%2Fpytest%2F1.0.6650&pr=4799&service=appveyor&build=r1cx4er7tmmd98ul&slug=pytest-dev%2Fpytest&package=py2.0.15
 Pinging Codecov...
Error: HTTPSConnectionPool(host='codecov.io', port=443): Max retries exceeded with url: /upload/v4?commit=7e9f35e6cba84c386d29fc45e28d60b64927f753&branch=master&job=pytestbot%2Fpytest%2F1.0.6650&pr=4799&service=appveyor&build=r1cx4er7tmmd98ul&slug=pytest-dev%2Fpytest&package=py2.0.15 (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x02DFC030>: Failed to establish a new connection: [WinError 10060] A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond',))

Tip: See all example repositories: https://github.com/codecov?query=example
Support channels:
 Email: hello@codecov.io
 IRC: #codecov
 Gitter: https://gitter.im/codecov/support
 Twitter: @codecov

Sorry, we tried running command for 3 times and all attempts were unsuccessful!

[quantus]

I've also seen quite a few similar connection errors from our CircleCI builds. My current solution for the issue has been running codecov like this:

codecov --required || (sleep 5 && codecov --required) || (sleep 5 && codecov --required) || (sleep 5 && codecov --required) || (sleep 5 && codecov --required)

I know it isn't pretty but I haven't seen it failing yet.

[timandy]

I got the same issue
Could add a parameter to specify the number of retries?

1748 _____ _
1749 / ____| | |
1750 | | ___ __| | ___ ___ _____ __
1751 | | / _ \ / _ |/ _ \/ __/ _ \ \ / /
1752 | |___| (_) | (_| | __/ (_| (_) \ V /
1753 \_____\___/ \____|\___|\___\___/ \_/
1754 v2.0.15
1755
1756==> Detecting CI provider
1757 Travis Detected
1758==> Preparing upload
1759==> Processing gcov (disable by -X gcov)
1760 Executing gcov (find /home/travis/build/timandy/linq -not -path './bower_components/**' -not -path './node_modules/**' -not -path './vendor/**' -type f -name '*.gcno' -exec gcov -pb {} +)
1761==> Collecting reports
1762 + /home/travis/build/timandy/linq/target/site/jacoco/jacoco.xml bytes=1354762
1763==> Appending environment variables
1764 + TRAVIS_JDK_VERSION
1765 + TRAVIS_OS_NAME
1766==> Uploading
1767 .url https://codecov.io
1768 .query pr=false&service=travis&package=py2.0.15&job=573661452&build=230.1&branch=master&commit=f768b4f9b4b1cd2acdf5152d0f7be269a22793c0&slug=timandy%2Flinq
1769 Pinging Codecov...
1770 Uploading to S3...
1771Error: HTTPSConnectionPool(host='codecov.io', port=443): Max retries exceeded with url: /codecov/v4/raw/2019-08-19/BD907C23C2C05F757F59BF33F38DF67D/f768b4f9b4b1cd2acdf5152d0f7be269a22793c0/7d85c4bc-4456-43cd-9289-81a22b1c23b1.txt?AWSAccessKeyId=AKIAIHLZSCQCS4WIHD4A&Expires=1566195120&Signature=Hj%2BcQ2c4lj7zLAMWUejjidNN6DU%3D (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x7fb360244390>: Failed to establish a new connection: [Errno 110] Connection timed out',))
1772
1773Tip: See an example jdk repo: https://github.com/codecov/example-jdk
1774Support channels:
1775 Email: hello@codecov.io
1776 IRC: #codecov
1777 Gitter: https://gitter.im/codecov/support
1778 Twitter: @codecov
1779
1780
1781