Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Added GitHub Actions CI detection. - #265

Merged
thomasrockhu merged 1 commit into
codecov:masterfrom
nmoinvaz:improvements/github-actions
Jun 8, 2020
Merged

Added GitHub Actions CI detection.#265
thomasrockhu merged 1 commit into
codecov:masterfrom
nmoinvaz:improvements/github-actions

Conversation

@nmoinvaz

Copy link
Copy Markdown
Contributor

I initially had to do this before GitHub Actions was public. I now updated/copied from the bash uploader.

@codecov

codecovBot commented May 27, 2020

Copy link
Copy Markdown

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #265 +/- ##
=====================================
Coverage 88% 88% =====================================
Files 2 2 Lines 9 9 =====================================
Hits 8 8 Misses 1 1 

@hoefling

Copy link
Copy Markdown

@nmoinvaz shouldn't this obsolete the necessity of passing the token explicitly? When trying the tokenless upload, I still get the message Error: Missing repository upload token (example job, install codecov from this PR). No issue when using the bash uploader, though (example job using bash uploader).

@nmoinvaz

Copy link
Copy Markdown
ContributorAuthor

I'm not sure how tokenless works. This PR only gets the environment variable values when running on GitHub Actions environment and uses them in the upload to Codecov.

@alecgerona

Copy link
Copy Markdown

Any updates on this? This is especially useful for running tests inside tox since it has issues running the bash uploader. It can't detect if it's running from Github Actions.

@thomasrockhu

Copy link
Copy Markdown
Contributor

Thanks @nmoinvaz on this, could we get some tests for this new behavior?

@thomasrockhu
thomasrockhu self-requested a review June 6, 2020 18:23
@nmoinvaz

Copy link
Copy Markdown
ContributorAuthor

Done.

@thomasrockhu
thomasrockhu merged commit 48a5613 into codecov:masterJun 8, 2020

@thomasrockhuthomasrockhu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@nmoinvaznmoinvaz mentioned this pull request Jun 14, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@nmoinvaz@hoefling@alecgerona@thomasrockhu