Skip to content
This repository was archived by the owner on May 21, 2025. It is now read-only.

Fix error try_to_run using | without shell=True (fix #284) - #298

Merged
thomasrockhu merged 1 commit into
codecov:masterfrom
paugier:fix-pipe-hg-id
Sep 21, 2020
Merged

Fix error try_to_run using | without shell=True (fix #284)#298
thomasrockhu merged 1 commit into
codecov:masterfrom
paugier:fix-pipe-hg-id

Conversation

@paugier

@paugierpaugier commented Sep 18, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

With ['hg', 'log', '-r', '.', '-T', '{node}'] to avoid shell=True.

Should fix#284

@codecov

codecovBot commented Sep 18, 2020

Copy link
Copy Markdown

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #298 +/- ##
=====================================
Coverage 88% 88% =====================================
Files 2 2 Lines 9 9 =====================================
Hits 8 8 Misses 1 1

@thomasrockhu

thomasrockhu commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Thanks for this @paugier!

@thomasrockhu
thomasrockhu merged commit 713d941 into codecov:masterSep 21, 2020
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@thomasrockhuthomasrockhuthomasrockhu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

hg identify call fails because it uses a |, but try_to_run() is missing shell=True

2 participants

@paugier@thomasrockhu