Skip to content
This repository was archived by the owner on Aug 5, 2026. It is now read-only.

Remove some unneeded dependencies - #425

Merged
Swatinem merged 1 commit into
mainfrom
swatinem/rm-compat-deps
Nov 14, 2024
Merged

Remove some unneeded dependencies#425
Swatinem merged 1 commit into
mainfrom
swatinem/rm-compat-deps

Conversation

@Swatinem

Copy link
Copy Markdown
Contributor

This removes a bunch of dependencies which were only needed for forward compatibility across Python versions, as well as some very niche dependencies with well-established alternatives.


This is extracted from #423, and ships a few improvements and blockers before fully switching to uv.

@Swatinem
Swatinem requested a review from a teamNovember 14, 2024 11:07
@SwatinemSwatinem self-assigned this Nov 14, 2024
This removes a bunch of dependencies which were only needed for forward compatibility across Python versions, as well as some very niche dependencies with well-established alternatives.
@Swatinem
Swatinemforce-pushed the swatinem/rm-compat-deps branch from dc7dba3 to 3e5c971CompareNovember 14, 2024 11:08
@codecov

codecovBot commented Nov 14, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.79%. Comparing base (26f0db0) to head (3e5c971).
Report is 2 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@## main #425 +/- ##
==========================================
- Coverage 90.23% 89.79% -0.45% 
==========================================
Files 389 324 -65 Lines 11802 9457 -2345 Branches 2063 1688 -375 ==========================================
- Hits 10650 8492 -2158 + Misses 1052 901 -151 + Partials 100 64 -36 
FlagCoverage Δ
shared-docker-uploader?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Swatinem
Swatinem added this pull request to the merge queueNov 14, 2024
Merged via the queue into main with commit bb18502Nov 14, 2024
@Swatinem
Swatinem deleted the swatinem/rm-compat-deps branch November 14, 2024 16:15
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Swatinem@michelletran-sentry