Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Stop writing UploadLevelTotals - #671

Draft
Swatinem wants to merge 1 commit into
mainfrom
swatinem/rm-ult
Draft

Stop writing UploadLevelTotals#671
Swatinem wants to merge 1 commit into
mainfrom
swatinem/rm-ult

Conversation

@Swatinem

Copy link
Copy Markdown
Contributor

I believe these are completely unused. They were still being created/updated though.

@Swatinem
Swatinem requested a review from a teamSeptember 2, 2024 11:54
@SwatinemSwatinem self-assigned this Sep 2, 2024
@codecov-notifications

codecov-notificationsBot commented Sep 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@ Coverage Diff @@## main #671 +/- ##
==========================================
- Coverage 97.94% 97.93% -0.01% 
==========================================
Files 435 434 -1 Lines 36925 36581 -344 ==========================================
- Hits 36165 35827 -338 + Misses 760 754 -6 
FlagCoverage Δ
integration97.93% <100.00%> (-0.01%)⬇️
latest-uploader-overall97.93% <100.00%> (-0.01%)⬇️
unit97.93% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode95.63% <100.00%> (-0.01%)⬇️
OutsideTasks98.04% <100.00%> (+<0.01%)⬆️
FilesCoverage Δ
database/tests/factories/core.py99.34% <ø> (-0.05%)⬇️
services/report/__init__.py96.21% <100.00%> (-0.10%)⬇️
services/tests/test_report.py100.00% <ø> (ø)

... and 37 files with indirect coverage changes

@codecov-qa

codecov-qaBot commented Sep 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (66ca059) to head (d0fb6ee).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@ Coverage Diff @@## main #671 +/- ##
==========================================
- Coverage 97.94% 97.93% -0.01% 
==========================================
Files 435 434 -1 Lines 36925 36581 -344 ==========================================
- Hits 36165 35827 -338 + Misses 760 754 -6 
FlagCoverage Δ
integration97.93% <100.00%> (-0.01%)⬇️
latest-uploader-overall97.93% <100.00%> (-0.01%)⬇️
unit97.93% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode95.63% <100.00%> (-0.01%)⬇️
OutsideTasks98.04% <100.00%> (+<0.01%)⬆️
Files with missing linesCoverage Δ
database/tests/factories/core.py99.34% <ø> (-0.05%)⬇️
services/report/__init__.py96.21% <100.00%> (-0.10%)⬇️
services/tests/test_report.py100.00% <ø> (ø)

... and 37 files with indirect coverage changes

@codecov

codecovBot commented Sep 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.98%. Comparing base (66ca059) to head (d0fb6ee).
Report is 1 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #671 +/- ##
==========================================
- Coverage 97.99% 97.98% -0.01% 
==========================================
Files 476 474 -2 Lines 38251 37907 -344 ==========================================
- Hits 37483 37145 -338 + Misses 768 762 -6 
FlagCoverage Δ
integration97.93% <100.00%> (-0.01%)⬇️
latest-uploader-overall97.93% <100.00%> (-0.01%)⬇️
unit97.93% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode95.75% <100.00%> (-0.01%)⬇️
OutsideTasks98.04% <100.00%> (+<0.01%)⬆️
Files with missing linesCoverage Δ
database/tests/factories/core.py100.00% <ø> (ø)
services/report/__init__.pyCritical96.22% <100.00%> (-0.10%)⬇️
services/tests/test_report.py100.00% <ø> (ø)

... and 38 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.Upload
run/app.tasks.upload.UploadProcessor
run/app.tasks.upload.PreProcessUpload

@codecov-public-qa

codecov-public-qaBot commented Sep 2, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (66ca059) to head (d0fb6ee).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@ Coverage Diff @@## main #671 +/- ##
==========================================
- Coverage 97.94% 97.93% -0.01% 
==========================================
Files 435 434 -1 Lines 36925 36581 -344 ==========================================
- Hits 36165 35827 -338 + Misses 760 754 -6 
FlagCoverage Δ
integration97.93% <100.00%> (-0.01%)⬇️
latest-uploader-overall97.93% <100.00%> (-0.01%)⬇️
unit97.93% <100.00%> (-0.01%)⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode95.63% <100.00%> (-0.01%)⬇️
OutsideTasks98.04% <100.00%> (+<0.01%)⬆️
FilesCoverage Δ
database/tests/factories/core.py99.34% <ø> (-0.05%)⬇️
services/report/__init__.py96.21% <100.00%> (-0.10%)⬇️
services/tests/test_report.py100.00% <ø> (ø)

... and 37 files with indirect coverage changes

I believe these are completely unused. They were still being created/updated though.
@adrian-codecov

Copy link
Copy Markdown
Contributor

@Swatinem do we still need this?

@Swatinem

Copy link
Copy Markdown
ContributorAuthor

I would like to still do this, yes. Though I believe I have hit a roadblock back then when working on the API changes.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Swatinem@adrian-codecov