Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

ref: Remove dollar signs from email templates - #887

Open
spalmurray-codecov wants to merge 2 commits into
mainfrom
spalmurray/billing-email-dollar-sign
Open

ref: Remove dollar signs from email templates#887
spalmurray-codecov wants to merge 2 commits into
mainfrom
spalmurray/billing-email-dollar-sign

Conversation

@spalmurray-codecov

Copy link
Copy Markdown
Contributor

Going to have the caller specify the currency string instead of just a number. Easy to do now to make supporting more currency formats easier in the future.

@spalmurray-codecov
spalmurray-codecov marked this pull request as ready for review November 12, 2024 23:10
@spalmurray-codecov
spalmurray-codecovforce-pushed the spalmurray/billing-email-dollar-sign branch from e751626 to 2606688CompareNovember 12, 2024 23:11
@codecov

codecovBot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (b6854d4) to head (2606688).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@ Coverage Diff @@## main #887 +/- ##
=======================================
Coverage 98.00% 98.00% =======================================
Files 444 444 Lines 35420 35420 =======================================
Hits 34712 34712 Misses 708 708 
FlagCoverage Δ
integration41.95% <ø> (ø)
unit90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode96.02% <ø> (ø)
OutsideTasks95.86% <ø> (ø)

@codecov-notifications

codecov-notificationsBot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@ Coverage Diff @@## main #887 +/- ##
=======================================
Coverage 98.00% 98.00% =======================================
Files 444 444 Lines 35420 35420 =======================================
Hits 34712 34712 Misses 708 708 
FlagCoverage Δ
integration41.95% <ø> (ø)
unit90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode96.02% <ø> (ø)
OutsideTasks95.86% <ø> (ø)

@codecov-qa

codecov-qaBot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (b6854d4) to head (2606688).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@ Coverage Diff @@## main #887 +/- ##
=======================================
Coverage 98.00% 98.00% =======================================
Files 444 444 Lines 35420 35420 =======================================
Hits 34712 34712 Misses 708 708 
FlagCoverage Δ
integration41.95% <ø> (ø)
unit90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode96.02% <ø> (ø)
OutsideTasks95.86% <ø> (ø)

@codecov-public-qa

codecov-public-qaBot commented Nov 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.00%. Comparing base (b6854d4) to head (2606688).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@ Coverage Diff @@## main #887 +/- ##
=======================================
Coverage 98.00% 98.00% =======================================
Files 444 444 Lines 35420 35420 =======================================
Hits 34712 34712 Misses 708 708 
FlagCoverage Δ
integration41.95% <ø> (ø)
unit90.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

ComponentsCoverage Δ
NonTestCode96.02% <ø> (ø)
OutsideTasks95.86% <ø> (ø)

@github-actions

Copy link
Copy Markdown

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@spalmurray-codecov@ajay-sentry@spalmurray