fix: Java security and validation improvements - #1267
Merged
Conversation
Security fixes: - Add validation for test class names to prevent command injection (CVE-level) - Implement safe XML parsing to prevent XXE attacks - Add input sanitization for Maven test filters Error handling improvements: - Add robust error handling for malformed XML in Surefire reports - Handle invalid numeric values in test result attributes - Add try-catch blocks around integer conversions Changes: - test_runner.py: Add _validate_java_class_name() and _validate_test_filter() - test_runner.py: Validate test class names before passing to Maven - build_tools.py: Add _safe_parse_xml() for secure XML parsing - build_tools.py: Replace all ET.parse() calls with secure version - build_tools.py: Add validation for numeric XML attributes Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Added test coverage for: - Input validation (command injection prevention) - Test class name validation with positive and negative cases - Test filter validation including wildcards - XML parsing security (XXE attack prevention) - Error handling for malformed XML - Error handling for invalid numeric attributes - Edge cases (empty strings, whitespace, special characters) All tests pass. This ensures the security fixes work correctly and prevents regressions. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Ubuntu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
misrasaurabh1
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses critical security vulnerabilities and improves error handling in the CodeFlash Java implementation.
Security Fixes
Error Handling Improvements
Changes
test_runner.py:
_validate_java_class_name()to validate Java identifier syntax_validate_test_filter()to sanitize test filter stringsget_test_run_command()before passing to Mavenbuild_tools.py:
_safe_parse_xml()for secure XML parsingET.parse()calls with secure versionTest Coverage
Added comprehensive test suite (
test_security.py) with 16 tests covering:All tests pass ✅
Impact
Test plan