Skip to content

⚡️ Speed up function _extract_function_from_code by 11% in PR #1256 (refactor/use-function-to-optimize-in-js) #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up function _extract_function_from_code by 11% in PR #1256 (refactor/use-function-to-optimize-in-js) #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions codeflash/code_utils/code_replacer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
from codeflash.code_utils.line_profile_utils import ImportAdder
from codeflash.languages import is_python
from codeflash.models.models import FunctionParent
import logging

if TYPE_CHECKING:
from pathlib import Path
Expand Down Expand Up @@ -601,13 +602,19 @@ def _extract_function_from_code(
if func.function_name == function_name:
# Extract the function's source using line numbers
# Use doc_start_line if available to include JSDoc/docstring
lines = source_code.splitlines(keepends=True)
# Extract the function's source using line numbers
# Use doc_start_line if available to include JSDoc/docstring
effective_start = func.doc_start_line or func.starting_line
# Only split the source into lines if we have valid start/end info
if not (effective_start and func.ending_line):
continue
lines = source_code.splitlines(keepends=True)
if effective_start and func.ending_line and effective_start <= len(lines):
func_lines = lines[effective_start - 1 : func.ending_line]
return "".join(func_lines)
except Exception as e:
logger.debug(f"Error extracting function {function_name}: {e}")
if logger.isEnabledFor(logging.DEBUG):
logger.debug(f"Error extracting function {function_name}: {e}")

return None

Expand Down
Loading