You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
✅ All checks pass — ruff check and ruff format both passed with no issues.
Mypy
⚠️ 60 no-untyped-def errors in tests/test_languages/test_treesitter_utils.py — all are missing return type annotations on test methods. This is a pre-existing pattern across the entire file (same style on main branch), not introduced by this PR. No action needed.
Code Review
No critical issues found. Summary of changes:
packages/codeflash/scripts/postinstall.js — Changes install strategy to prefer GitHub clone over PyPI:
Adds hasGit() helper to check for git availability
Modifies installCodeflash() to first try git+https://github.com/codeflash-ai/codeflash.git, falling back to PyPI
Removes old local-source fallback (tried to install from local pyproject.toml)
The hardcoded GitHub URL avoids injection risks. Shell quoting for uvBin is consistent with existing patterns.
tests/test_languages/test_treesitter_utils.py — Adds 10 new tests for export const arrow function patterns in TypeScript:
All tested API methods (is_function_exported, find_functions, has_return_statement) verified to exist on TreeSitterAnalyzer
Test Coverage
File
Status
Notes
packages/codeflash/scripts/postinstall.js
N/A
JavaScript file — not covered by Python test suite
tests/test_languages/test_treesitter_utils.py
✅ Test file
10 new tests added, all passing
No production Python files were modified in this PR, so there is no Python coverage delta to measure. The new tests exercise codeflash/languages/treesitter_utils.py (TreeSitterAnalyzer, FunctionNode, ImportInfo) which improves coverage of that module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.