Skip to content

⚡️ Speed up method JavaLineProfiler._instrument_function by 71% in PR #1484 (fix/java-line-profiler-else-if) #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up method JavaLineProfiler._instrument_function by 71% in PR #1484 (fix/java-line-profiler-else-if) #1485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 20 additions & 21 deletions codeflash/languages/java/line_profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,12 @@ def _instrument_function(
# Add profiling to each executable line
function_entry_added = False


# Precompute constants used in loop
profiler_class = self.profiler_class
file_path_posix = file_path.as_posix()
enter_function_call = f"{profiler_class}.enterFunction();\n"

for local_idx, line in enumerate(func_lines):
local_line_num = local_idx + 1 # 1-indexed within function
global_line_num = func.starting_line + local_idx # Global line number
Expand All @@ -296,9 +302,7 @@ def _instrument_function(

# Add the line with enterFunction() call after it
instrumented_lines.append(line)
instrumented_lines.append(
f"{body_indent}{self.profiler_class}.enterFunction();\n"
)
instrumented_lines.append(f"{body_indent}{enter_function_call}")
function_entry_added = True
continue

Expand All @@ -317,21 +321,21 @@ def _instrument_function(
is_standalone_else_or_finally = False
if not is_else_if: # Only check if it's not else-if
# Check for standalone else
if (stripped.startswith("else{") or stripped.startswith("else {") or
stripped.startswith("} else{") or stripped.startswith("} else {") or
stripped == "else"):
if stripped.startswith(("else{", "else {", "} else{", "} else {")) or stripped == "else":
is_standalone_else_or_finally = True
# Check for finally
elif (stripped.startswith("finally{") or stripped.startswith("finally {") or
stripped.startswith("} finally{") or stripped.startswith("} finally {") or
stripped == "finally"):
elif stripped.startswith(("finally{", "finally {", "} finally{", "} finally {")) or stripped == "finally":
is_standalone_else_or_finally = True

# For catch: Cannot instrument before it (syntax error), but should track it
# Python tracks "except" lines, so we should track "catch" lines
# Solution: Detect catch and handle it specially (see below)
is_catch = (stripped.startswith("catch ") or stripped.startswith("catch(") or
stripped.startswith("} catch ") or stripped.startswith("} catch("))
is_catch = stripped.startswith(("catch ", "catch(", "} catch ", "} catch("))

# Determine if we should skip instrumenting BEFORE this line
# Skip standalone else/finally (matches Python)
# Also skip else-if - it's tracked by tree-sitter marking it as executable,
# but we can't insert code before it (syntax error)

# Determine if we should skip instrumenting BEFORE this line
# Skip standalone else/finally (matches Python)
Expand All @@ -342,19 +346,16 @@ def _instrument_function(
if (
local_line_num in executable_lines
and stripped
and not stripped.startswith("//")
and not stripped.startswith("/*")
and not stripped.startswith("*")
and stripped != "}"
and stripped != "};"
and not stripped.startswith(("//", "/*", "*"))
and stripped not in ("}", "};")
and not should_skip
):
# Get indentation
indent = len(line) - len(line.lstrip())
indent_str = " " * indent

# Store line content for profiler output
content_key = f"{file_path.as_posix()}:{global_line_num}"
content_key = f"{file_path_posix}:{global_line_num}"
self.line_contents[content_key] = stripped

# Special handling for catch and else-if blocks
Expand All @@ -378,14 +379,12 @@ def _instrument_function(
# - catch → except (Python tracks except lines)
# - else if → elif (Python tracks elif lines)
instrumented_lines.append(
f"{body_indent}{self.profiler_class}.hit("
f'"{file_path.as_posix()}", {global_line_num});\n'
f'{body_indent}{profiler_class}.hit("{file_path_posix}", {global_line_num});\n'
)
else:
# Normal case: Add hit() call before the line
profiled_line = (
f"{indent_str}{self.profiler_class}.hit("
f'"{file_path.as_posix()}", {global_line_num});\n{line}'
f'{indent_str}{profiler_class}.hit("{file_path_posix}", {global_line_num});\n{line}'
)
instrumented_lines.append(profiled_line)
else:
Expand Down
Loading