Skip to content

⚡️ Speed up method RenderCallTransformer._parse_render_call by 22% in PR #1561 (add/support_react) #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up method RenderCallTransformer._parse_render_call by 22% in PR #1561 (add/support_react) #1647

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions codeflash/languages/javascript/instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,11 +873,14 @@ def _parse_render_call(self, code: str, match: re.Match) -> RenderCallMatch | No
# Position after ComponentName
pos = match.end()

# Cache length to avoid repeated calls in hot loop
len_code = len(code)

# Skip whitespace
while pos < len(code) and code[pos] in " \t\n\r":
while pos < len_code and code[pos] in " \t\n\r":
pos += 1

if pos >= len(code):
if pos >= len_code:
return None

create_element_args = ""
Expand All @@ -890,7 +893,7 @@ def _parse_render_call(self, code: str, match: re.Match) -> RenderCallMatch | No
in_string = False
string_char = None

while pos < len(code) and depth > 0:
while pos < len_code and depth > 0:
char = code[pos]
if char in "\"'`" and (pos == 0 or code[pos - 1] != "\\"):
if not in_string:
Expand All @@ -899,7 +902,10 @@ def _parse_render_call(self, code: str, match: re.Match) -> RenderCallMatch | No
elif char == string_char:
in_string = False
string_char = None
elif not in_string:
pos += 1
continue

if not in_string:
if char == "(":
depth += 1
elif char == ")":
Expand All @@ -910,7 +916,8 @@ def _parse_render_call(self, code: str, match: re.Match) -> RenderCallMatch | No
return None

# pos-1 is the closing ) of createElement/_jsx
create_element_args = code[args_start : pos - 1].strip()
create_element_args = code[args_start: pos - 1].strip()


elif code[pos] == ")":
# No args: React.createElement(Counter) or _jsx(Counter)
Expand All @@ -919,22 +926,23 @@ def _parse_render_call(self, code: str, match: re.Match) -> RenderCallMatch | No
return None

# Skip whitespace between createElement closing ) and render closing )
while pos < len(code) and code[pos] in " \t\n\r":
while pos < len_code and code[pos] in " \t\n\r":
pos += 1

# Expect closing ) of render(
# If we see a comma instead, render has additional options - skip this match
if pos >= len(code) or code[pos] != ")":
if pos >= len_code or code[pos] != ")":
return None

pos += 1 # skip ) of render

# Check for trailing semicolon
end_pos = pos
while end_pos < len(code) and code[end_pos] in " \t":
# Only skip spaces and tabs per original behavior
while end_pos < len_code and code[end_pos] in " \t":
end_pos += 1

has_trailing_semicolon = end_pos < len(code) and code[end_pos] == ";"
has_trailing_semicolon = end_pos < len_code and code[end_pos] == ";"
if has_trailing_semicolon:
end_pos += 1

Expand Down
Loading