Skip to content

⚡️ Speed up function _is_jsx_component_usage by 83% in PR #1561 (add/support_react) #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
codeflash-ai wants to merge 1 commit into from
Closed

⚡️ Speed up function _is_jsx_component_usage by 83% in PR #1561 (add/support_react) #1653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions codeflash/languages/javascript/instrument.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
from codeflash.code_utils.code_position import CodePosition
from codeflash.discovery.functions_to_optimize import FunctionToOptimize

_RENDER_CALL_RE = re.compile(r"\brender\s*\(")


class TestingMode:
"""Testing mode constants."""
Expand Down Expand Up @@ -1192,10 +1194,13 @@ def _is_jsx_component_usage(code: str, func_name: str) -> bool:
"""
# Check for JSX usage: <ComponentName or <ComponentName> or <ComponentName />
jsx_pattern = rf"<\s*{re.escape(func_name)}[\s>/]"
# Fast-fail cheap substring checks to avoid regex work when possible.
if "render" not in code or "<" not in code or func_name not in code:
return False
# Use the precompiled render regex for correctness and efficiency.
if not re.search(jsx_pattern, code):
return False
# Also verify there's a render() call (from @testing-library/react or similar)
return bool(re.search(r"\brender\s*\(", code))
return bool(_RENDER_CALL_RE.search(code))


def _is_function_used_in_test(code: str, func_name: str) -> bool:
Expand Down
Loading