Skip to content

⚡️ Speed up function _extract_gradle_include_modules by 22% in PR #1906 (cf-java-zero-config-strategy) #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mashraf-222 merged 1 commit into from
Mar 26, 2026
Merged

⚡️ Speed up function _extract_gradle_include_modules by 22% in PR #1906 (cf-java-zero-config-strategy) #1908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions codeflash/languages/java/gradle_strategy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@
from codeflash.languages.java.build_tool_strategy import BuildToolStrategy, module_to_dir
from codeflash.languages.java.build_tools import BuildTool, JavaProjectInfo

_RE_INCLUDE = re.compile(r"""include\s*\(?([^)\n]+)\)?""")

_RE_QUOTED = re.compile(r"""['"]([^'"]+)['"]""")

_BUILD = "build"

logger = logging.getLogger(__name__)
Expand Down Expand Up @@ -322,9 +326,9 @@ def _normalize_gradle_xml_reports(reports_dir: Path) -> None:
def _extract_gradle_include_modules(content: str) -> list[str]:
"""Extract module names from include() directives in settings.gradle."""
modules: list[str] = []
for match in re.finditer(r"""include\s*\(?([^)\n]+)\)?""", content):
for match in _RE_INCLUDE.finditer(content):
args = match.group(1)
for quoted in re.findall(r"""['"]([^'"]+)['"]""", args):
for quoted in _RE_QUOTED.findall(args):
module = quoted.lstrip(":")
if module:
modules.append(module)
Expand Down
Loading