Fix: codeflash package installation for pnpm workspaces and dev environments

[mohammedahmed18]

Problem

9 out of 13 optimization runs failed with Cannot find package 'codeflash' error because the codeflash npm package installation was failing.

Root causes:

1. PNPM workspace issue: When target project is a pnpm workspace, running pnpm add <package> requires -w flag to explicitly add to workspace root. Without it, installation fails with ERR_PNPM_ADDING_TO_ROOT.
2. Dev environment issue: In development (running from /opt/codeflash/), tried to install from npm registry but package either doesn't exist there or is wrong version. Should use local package at /opt/codeflash/packages/codeflash/.
3. Poor error visibility: Installation errors logged at WARNING level instead of ERROR, making issues hard to diagnose.

Solution

1. Workspace detection: Added _is_pnpm_workspace() function to detect pnpm-workspace.yaml and append -w flag when needed.
2. Local package in dev: Added _get_local_codeflash_package_path() to detect dev environment and use local package path instead of npm package name.
3. Better error logging: Changed installation failure logging from WARNING to ERROR level with full stderr output.

Testing

• Added unit tests for both workspace detection and local package usage
• Manually verified installation works in target project (openclaw workspace)
• Confirmed codeflash package can be imported after installation
• All linting and type checks pass

Impact

Fixes optimization failures in these trace IDs:

• 08d594a2-94c6-4549-a1e2-059f4979ee24
• 1722cff7-eb47-4bbd-94ea-b36d64b6a9c4
• 23480bf7-a269-431d-abf5-f43c1c058e80
• 3074f19b-75d4-44b5-9ab6-566600fb374f
• 6043236e-2ce4-4a7b-a2fe-cf7ce048b319
• b883f1bd-061e-4cb7-b9ee-339fbe063ce8
• d01b03ce-a521-4f4c-acfd-ff705f47bc9e
• e56507a4-4bdf-49f3-840b-a6ee64c14e27
• f8f54e06-0a70-4a25-9fa0-d85a8cf29c67

[claude]

Claude finished @mohammedahmed18's task in 3m 34s —— View job

---

PR Review Summary

Triage

LARGE (108 additions across 5 files, including 55-line test file and 44 lines of new production logic).

Prek Checks

All ruff checks pass. No linting or formatting issues.

---

Code Review

1. Test file is in the wrong location — codeflash/cli_cmds/test_init_javascript_workspace.py

The test file is co-located with the source in cli_cmds/, but the project convention is to put all tests under tests/. There's already a tests/test_init_javascript.py that tests init_javascript.py — the new tests should be added there instead. Fix this →

2. Tests violate tmp_path convention — codeflash/cli_cmds/test_init_javascript_workspace.py:10,32

Both tests use tempfile.TemporaryDirectory(). Per .claude/rules/testing.md: "Use pytest's tmp_path fixture for temp directories — do not use tempfile.TemporaryDirectory()." The existing tests/test_init_javascript.py already uses tmp_path via a tmp_project fixture as the pattern to follow. Fix this →

3. test_dev_environment_uses_local_package always passes — the test is meaningless — codeflash/cli_cmds/test_init_javascript_workspace.py:48-52

assert (
    "/opt/codeflash/packages/codeflash" in cmd_str
    or "file:" in cmd_str
    or cmd[0] in ["npm", "pnpm", "yarn", "bun"]   # ← always True
)

The third condition is always true because get_package_install_command always returns a command starting with one of these package managers. This test can never fail and provides zero coverage of the actual dev-env detection logic. The test should mock _get_local_codeflash_package_path to return a known path and assert that path appears in the command. Fix this →

4. Hardcoded /opt/codeflash path is fragile — codeflash/cli_cmds/init_javascript.py:209

if "/opt/codeflash" in str(codeflash_python_path):

This hardcodes a deployment-specific filesystem path. If the dev environment moves (or if someone's dev setup uses a different path), the detection silently fails. An explicit env variable (CODEFLASH_DEV_JS_PACKAGE_PATH or similar) would be more robust and testable. As written, this logic is also untestable without the exact path structure being present.

5. Docstrings added to new private functions — codeflash/cli_cmds/init_javascript.py:184,197

Per code style rules: "Do not add docstrings to new or changed code unless the user explicitly asks for them." Both _is_pnpm_workspace and _get_local_codeflash_package_path have full docstrings. These should be removed. Fix this →

---

Duplicate Detection

The _ensure_runtime_files function is identically implemented in three files (mocha_runner.py:62, test_runner.py:706, vitest_runner.py:92) — this is a pre-existing issue, not introduced by this PR. The PR correctly applies the same logging fix to all three copies.

No new duplicates introduced.

---

Test Coverage

The new _is_pnpm_workspace and get_package_install_command (with workspace flag) logic has basic coverage via the new test. However, the dev-env detection test is effectively a no-op (see finding #3 above).

---