Uh oh!
There was an error while loading. Please reload this page.
feat: wire SolutionServer into agents.Serve (#290) - #291
Merged
antoinetoussaint-byte merged 2 commits intoAug 16, 2026
Conversation
Add a Solution field to PluginRegistration and register it during agent startup, so a solution plugin can expose its gRPC contract through the standard Serve() path alongside Provider and the other capabilities. Extract the unconditional server registrations into a testable registerServices helper and cover Solution registration with a test. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The prior test asserted a private registerServices helper via GetServiceInfo, so it could not catch a regression that stopped Serve from calling the registration (both tests passed against the helper, not against Serve). The helper existed only to enable that weaker test. Register Solution inline in Serve exactly like Provider (dropping the helper), and replace the unit test with a real spawn test: it builds a testdata solution agent, starts it through Serve, dials over gRPC, and asserts a Solution RPC routes to the fixture handler. Removing the registration in Serve now surfaces as an Unimplemented "unknown service" error — verified by temporarily deleting the registration. No mocks; the test drives the actual Serve path. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
antoinetoussaint-byte
merged commit Aug 16, 2026
80641fd
into
issue-287-new-agent-kind-codefly-solution-registry-entry-proto2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#290.
Stacked on #288 (the
codefly:solutioncontract from #287) — the base isissue-287-…and GitHub will retarget tomainonce #288 merges. The last commit here is the #290 change; the earlier commits belong to #287.Summary
agents.Serve()startup path —PluginRegistrationlacked aSolutionfield andServe()never registered one, unlikeProviderand the other capabilities.Solution solutionv0.SolutionServertoPluginRegistrationand registers it during startup, unblocking a solution binary serving its contract (obin-ai/lodestar#17).registerServiceshelper so the registration path is unit-testable without booting the blockingServe(); the env-dependent Toolbox/PDP path stays inServe.Test plan
go test ./agents/passes.TestRegisterServices_RegistersSolutionWhenSetasserts the Solution service appears ingrpc.Server.GetServiceInfo()when set.TestRegisterServices_SkipsSolutionWhenNilasserts it is absent when unset.go vet ./agents/clean.🤖 Generated with Claude Code