Uh oh!
There was an error while loading. Please reload this page.
fix(builder): correct SingleImageBuildPlan recipe paths (hotfix v0.3.7) - #339
Merged
Merged
Conversation
…ory contract The CLI (the recipe consumer) passes output_directory = <serviceDir>/builder and resolves recipe paths relative to it, with the build context "." mapping to the service directory. SingleImageBuildPlan emitted "builder/Dockerfile" and "builder/dockerignore" instead, so every recipe build failed validateRecipes against the real caller. Emit the Dockerfile and dockerignore relative to output_directory to match; the unit test that pinned the old layout was a false green (it constructed a tree the CLI never produces). Also from the review: - Detect the dockerignore with Lstat, consistent with the inventory's blanket symlink rejection, so a symlinked dockerignore never enters the recipe. - Warn instead of silently skipping when recipe emission was requested but a custom Docker context root forces the legacy in-process build. - Document why RecipeBuildPlatforms is a fixed multi-arch set and deliberately does not read the single-platform CODEFLY_BUILD_PLATFORM override. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v0.3.7 shipped the recipe contract from #336, but
SingleImageBuildPlanemits recipe paths under abuilder/subdirectory (Dockerfile: "builder/Dockerfile",builder/dockerignore). That does not match the already-implemented CLI consumer, which passesoutput_directory = <serviceDir>/builderand resolves recipe paths relative to it (recipeDockerfile(outputDir, {Dockerfile: "Dockerfile"}), context.→ the service dir).Result: any CLI-owned recipe build resolves the Dockerfile to
<serviceDir>/builder/builder/Dockerfile, which doesn't exist, and hard-failsvalidateRecipes. No CLI branch has pinned v0.3.7 yet, so nothing is broken in the wild — this corrects it before that happens.What
SingleImageBuildPlanemitsDockerfile/dockerignorerelative tooutput_directory(nobuilder/prefix), matching the CLI contract. The runner already renders the Dockerfile tolocation/builder/Dockerfile, which isoutput_directory/Dockerfile.os.Lstat(consistent with the inventory's blanket symlink rejection).RecipeBuildPlatformsis a fixed multi-arch set and does not readCODEFLY_BUILD_PLATFORM.Test
go test ./agents/services/ ./runners/golang/ ./runners/rust/green on Go 1.27.🤖 Generated with Claude Code