Bug: [ViewCells] private properties do not work with Computed Properties

[kenjis]

PHP Version

8.1

CodeIgniter4 Version

4.3.3 and develop fe7e2e4

CodeIgniter4 Installation Method

Git

Which operating systems have you tested for this bug?

macOS

Which server did you use?

apache

Database

No response

What happened?

See #7457 (comment)

Cannot access private property App\Cells\AlertMessageCell::$type
in SYSTEMPATH/Traits/PropertiesTrait.php on line 35.
 1 SYSTEMPATH/View/Cell.php(214): CodeIgniter\View\Cells\Cell->fill([...])
 2 SYSTEMPATH/View/Cell.php(99): CodeIgniter\View\Cell->renderCell(Object(App\Cells\AlertMessageCell), 'render', [...])
 3 SYSTEMPATH/Common.php(1200): CodeIgniter\View\Cell->render('AlertMessageCell', [...], 0, 'AppCellsAlertMessageCellrender3ab314af93d2044b8409e6348dd9ff46')

Steps to Reproduce

--- a/tests/_support/View/Cells/ListerCell.php
+++ b/tests/_support/View/Cells/ListerCell.php
@@ -15,7 +15,7 @@ use CodeIgniter\View\Cells\Cell;
 
 class ListerCell extends Cell
 {
- protected array $items = [];
+ private array $items = [];
 
 public function getItemsProperty()
 {

Expected Output

No error.

Anything else?

No response

[michalsn]

It seems like everything is good. The description for protected and private properties refers to the computed properties. The example you're showing here is something different:

 public function testCellWithComputedProperties()
 {
 $result = view_cell(ListerCell::class, ['items' => ['one', 'two', 'three']]);

The $items are added during cell initialization. This is why we are getting an error. We could never initialize properties that were private.

---

This would be a good example with using the private computed property:

// initializing
view_cell('AlertMessageCell', ['type' => 'note', 'message' => 'test']);

// cell
class AlertMessageCell extends Cell
{
 protected $type;
 protected $message;
 private $computed;

 public function mount()
 {
 $this->computed = sprintf('%s - %s', $this->type, $this->message);
 }

 public function getComputedProperty(): string
 {
 return $this->computed;
 }

 public function getTypeProperty(): string
 {
 return $this->type;
 }

 public function getMessageProperty(): string
 {
 return $this->message;
 }
}

// view
<div>
 <p>type - <?= $type; ?></p>
 <p>message - <?= $message; ?></p>
 <p>computed: <?= $computed; ?></p>
</div>

[kenjis]

You mean, we cannot pass the private computed properties in view_cell()?
If such is the specification, then the difference between protected and private makes sense.

[michalsn]

Yes, this is intended. We can't set properties that are declared as private during cell initialization. We can't allow passing values to every property because this would enable to override of any variable we defined.

[kenjis]

Okay, I send a PR #7460

[kenjis]

Closed by #7460