Uh oh!
There was an error while loading. Please reload this page.
docs: class defined as "Ping" but endpoints trying to fetch "Pings" - #10033
Conversation
Hi there, cjbaezilla! 👋 Thank you for sending this PR! We expect the following in all Pull Requests (PRs).
Important We expect all code changes or bug-fixes to be accompanied by one or more tests added to our test suite to prove the code works. If pull requests do not comply with the above, they will likely be closed. Since we are a team of volunteers, we don't have any more time to work See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/pull_request.md Sincerely, the mergeable bot 🤖 |
paulbalandan
commented
Mar 11, 2026
The plural endpoints were the review notes in #9808 when I picked that up. So I think it should be the other way around. Make the controller name as plural? |
neznaika0
commented
Mar 11, 2026
The ping example is unsuccessful - it does not imply a Domain. Therefore, ping looks reasonable, since and /api/login/api/auth/api/jwt/ |
michalsn
commented
Mar 11, 2026
In general, the plural form should be used for resources (most common REST style). Singular form for service-style endpoints. So I would agree with this change, since this is health/action endpoint. |
neznaika0
commented
Mar 13, 2026
Change spaces for table. |
paulbalandan
commented
Mar 16, 2026
@cjbaezilla would you be able to fix the failures so that this can be merged? |
cjbaezilla
commented
Mar 16, 2026
hello there @paulbalandan, i really have no idea how to pass the tests, and honestly don't have the time either to start looking around, i like the project and i saw the error so if anyone else want to get attributed for it please be my guest, thank you very much for your consideration in the matter, best regards. |
cjbaezilla
commented
Mar 17, 2026
this was the same rationale i made. |
Uh oh!
There was an error while loading. Please reload this page.
…a/CodeIgniter4 into fix-typo-api-userguide
3b44b5d to
04b655cCompareUh oh!
There was an error while loading. Please reload this page.
michalsn
commented
Mar 19, 2026
Thank you @cjbaezilla |
cjbaezilla
commented
Mar 19, 2026
Hooray! thanks guys have a great day 🤝 |
Title
Fix typo in user guide documentation first api page
Description
Class was defined as "Ping" but endpoints were pointing to "Pings" returning 404 in the example.
Checklist: