Skip to content

fix: support array indexes in getPostGet() and getGetPost() - #10362

Merged
paulbalandan merged 2 commits into
codeigniter4:developfrom
michalsn:fix/array-indexes-in-get-post
Jul 7, 2026
Merged

fix: support array indexes in getPostGet() and getGetPost()#10362
paulbalandan merged 2 commits into
codeigniter4:developfrom
michalsn:fix/array-indexes-in-get-post

Conversation

@michalsn

@michalsnmichalsn commented Jul 1, 2026

Copy link
Copy Markdown
Member

Description
This PR fixes IncomingRequest::getPostGet() and getGetPost() throwing a TypeError when passed an array of indexes. Each index now respects the expected GET/POST precedence, with tests and documentation updates.

Closes#10361

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsnmichalsn added the bug Verified issues on the current code behavior or pull requests that will fix them label Jul 1, 2026
@michalsn

michalsn commented Jul 1, 2026

Copy link
Copy Markdown
MemberAuthor

I will fix this PR after #10364 is merged.

@michalsn
michalsnforce-pushed the fix/array-indexes-in-get-post branch from d01ee87 to a11e4f4CompareJuly 2, 2026 05:25
@paulbalandanpaulbalandan changed the title fix: support array indexes in getPostGet() and getGetPost()fix: support array indexes in getPostGet() and getGetPost()Jul 7, 2026
@paulbalandan
paulbalandan merged commit 441c226 into codeigniter4:developJul 7, 2026
57 checks passed
@paulbalandan

paulbalandan commented Jul 7, 2026

Copy link
Copy Markdown
Member

Thank you, @michalsn

@michalsn
michalsn deleted the fix/array-indexes-in-get-post branch August 10, 2026 05:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandanpaulbalandanpaulbalandan approved these changes
+1 more reviewer
@datamwebdatamwebdatamweb approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bugVerified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: $this->request->getGetPost() is inconsistent with $this->request->getGet()

3 participants

@michalsn@paulbalandan@datamweb