getSegment() fixed with conditions changed

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249

[rajat315315]

Fixes#2962

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Can you fix up the failing test please?

https://travis-ci.org/github/codeigniter4/CodeIgniter4/jobs/704736451

[rajat315315]

Can somebody clarify the Unit test at:

CodeIgniter4/tests/system/Pager/PagerTest.php

Lines 428 to 432 in 8df97b9

	publicfunctiontestSegmentOutOfBound()
	{
	$this->pager->store('default', 10, 1, 10, 1000);
	$this->assertEquals(1, $this->pager->getCurrentPage());
	}

Is it correct?

I think L431 should be:

$this->assertEquals(10, $this->pager->getCurrentPage());

[michalsn]

This would be a BC change. Surprisingly this is not covered by the URITest class.

Let's say we have this address: http://example.com/one/two. Now, calling $uri->getSegment(3) originally would return "" (empty string) but after this change, it will throw an exception.

In URI class we have a "rule" that restrains throwing exception until the segment isn't greater than n+1 (where n i actually defined segment of URI).

Anyway, I think that #2962 is pretty much covered by introducing setSilent() method. Other things can't be changed now without introducing BC changes.

[ivantcholakov]

At the transition CI2 --> CI3 a convention was adopted. If a method does not "know" what to return, it returns NULL, not an empty string (edit: or FALSE sometimes). Is this valid for CI4?

[michalsn]

@ivantcholakov No, CI4 has quite different rules - at least by default.

[paulbalandan]

@michalsn are we still keeping this? or are we deferring this for a BC breaking version jump? If no, perhaps we can close this?

[michalsn]

Personally, I think people rely too much on the current implementation to change it in 4.1. We can revisit this at some point but I'll close it for now.

[kenjis]

See #7249