Handling requests sent back from filters - #3544

Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom
dcaswel:request-from-filters
Closed

Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom
dcaswel:request-from-filters

Conversation

@dcaswel

@dcasweldcaswel commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Expands the fix of #3085

Description
Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.

@dcasweldcaswel mentioned this pull request Aug 26, 2020
Closed
@dcaswel

dcaswel commented Aug 26, 2020

Copy link
Copy Markdown
ContributorAuthor

This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.

michalsn
michalsn requested changes Aug 27, 2020
View reviewed changes

@michalsnmichalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.

As for static analysis check - rebase should help.

MGatner
MGatner requested changes Aug 31, 2020
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.

Comment threadsystem/CodeIgniter.php
* Current request.
*
* @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
* @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface

@MGatnerMGatnerAug 31, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?

@samsonasiksamsonasikOct 18, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.

Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
{
return $possibleRedirect->send();

@MGatnerMGatnerAug 31, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.

lefuentesand others added 26 commits October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others added 23 commits October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik

samsonasik commented Oct 18, 2020

Copy link
Copy Markdown
Member

@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.

@paulbalandan

paulbalandan commented Nov 17, 2020

Copy link
Copy Markdown
Member

What's the status of this PR?

@MGatner

MGatner commented Nov 17, 2020

Copy link
Copy Markdown
Member

@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.

@dcaswel

dcaswel commented Nov 18, 2020

Copy link
Copy Markdown
ContributorAuthor

This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.

@dcasweldcaswel closed this Nov 18, 2020
@dcaswel
dcaswel deleted the request-from-filters branch November 18, 2020 02:40
@dcasweldcaswel mentioned this pull request Nov 18, 2020
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Handling requests sent back from filters - #3544
Closed
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Closed
Handling requests sent back from filters#3544
dcaswel wants to merge 328 commits into
codeigniter4:developfrom 
dcaswel:request-from-filters
Conversation
@dcaswel
@dcasweldcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

Contributor
Expands the fix of #3085
Description

Filters have the ability to alter the request like adding a user object from an auth filter for example. When it does that the request gets altered implicitly by the filter because the filter's request is pointing to the same object as the request property of the Codeigniter object. If the request gets altered, the filters also return the request into the $possibleRedirect variable. This change makes the update to the request property more explicit by setting the property with what gets returned from the filters. This ensures that if for some reason the object pointers get messed up, the request used by the controllers is the altered one.
@dcasweldcaswel
mentioned this pull request
Aug 26, 2020

Closed

@dcaswel
dcaswel
commented
Aug 26, 2020

Copy link


Copy Markdown

ContributorAuthor
This change worked in my local environment but it is causing a bunch of issues in the static analysis check so I will see if I can figure those out later. If anyone has an idea of what is going on there, I would appreciate the help.
michalsn
michalsn
requested changes
Aug 27, 2020
View reviewed changes
@michalsnmichalsn
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We would need some tests for this.
As for static analysis check - rebase should help.
MGatner
MGatner
requested changes
Aug 31, 2020
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right way to go. We will need some tests to verify that this works, and probably some User Guide mention (if it isn't already). I made a couple of logistic notes as well.
Comment threadsystem/CodeIgniter.php
 * Current request.
 *
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest
 * @var HTTP\Request|HTTP\IncomingRequest|CLIRequest|RequestInterface
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should all just be ReqiestInterface. @samsonasik ant compelling reason why the other hints would be needed?
@samsonasiksamsonasikOct 18, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if method caller use CLIRequest or IncomingRequest only method, that needed, if not, it can only use RequestInterface.
Comment threadsystem/CodeIgniter.php
@@ -434,6 +435,11 @@ protected function handleRequest(RouteCollectionInterface $routes = null, Cache
 {
 return $possibleRedirect->send();
@MGatnerMGatnerAug 31, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're here, I don't think there is any need to check for RedirectResponseandResponseInterface since they are handled the same. Let's remove the first block.
lefuentesand others
added 26 commits
October 17, 2020 17:42
@lefuentes@dcaswel
fix(Router): reset filter info before get defined filters (#3592)
ca87e5e
fix(Router): reset filter info before get defined filters
@paulbalandan@dcaswel
Refinements to Autoloader
f76cb2b
@michalsn@dcaswel
Fix current_url() helper function to correctly propagate the baseURL …
43dcc11
…when working in subfolder
@michalsn@dcaswel
Add slash at the end of host
a00f418
@michalsn@dcaswel
Make short HTTP protocol version acceptable
f498c50
@michalsn@dcaswel
Cast to float
1fc7c76
@paulbalandan@dcaswel
Add phpstan to pre-commit
712a949
@paulbalandan@dcaswel
Cache composer cache directory [ci skip]
b3bd451
@paulbalandan@dcaswel
Add XML tags normaliser
c2426d8
@paulbalandan@dcaswel
Add support for deep nested array
4c3c1db
@samsonasik@dcaswel
using EXIT_ERROR constant in CodeIgniter::bootstrapEnvironment()
18eb0d3
@samsonasik@dcaswel
Fix@PARAMat URI::stripQuery(...$params)
94d99d4
@michalsn@dcaswel
Remove all code and docs related to the database cache feature
d66c1d3
@michalsn@dcaswel
URI class update for better handling of URLs with sub-folders
f8bb13f
@michalsn@dcaswel
Parsing path changes
ca54fb3
@michalsn@samsonasik@dcaswel
Update system/HTTP/URI.php
6d06b43
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
@paulbalandan@dcaswel
Use view files for generator commands
8603cd9
@paulbalandan@dcaswel
Add config files for Generators
9735525
@paulbalandan@dcaswel
Allow generator commands' views to be configurable
d355460
@paulbalandan@dcaswel
Deprecate migrate:create for make:migration
08f417d
@michalsn@dcaswel
Fix URI class for proper subfolders handling
4f48d5f
@michalsn@dcaswel
Cast getBatches() result array
a7e66f5
@paulbalandan@dcaswel
Allow GeneratorCommand's sortImports to be configurable
1ad0a6a
@paulbalandan@dcaswel
Match 'use' at beginning of phrases only
3601c0b
@paulbalandan@dcaswel
Use DocBlocks to document Config classes' properties
c5fc3de
@paulbalandan@dcaswel
Resolve name clashes
4ebe331
paulbalandanand others
added 23 commits
October 17, 2020 17:42
@paulbalandan@dcaswel
Rebased and used Factories::reset('config')
3488ddc
@paulbalandan@dcaswel
Fix view caching with directory separators
faaafff
@MGatner@dcaswel
Correct parameter type
aba7255
@michalsn@dcaswel
Fix bug in parser with similar variable names
92cbc3f
@paulbalandan@dcaswel
Enclose CLI::generateDimensions in a try-catch
d4943bd
@samsonasik@dcaswel
Bug fix: ensure to use autoload = false in class_exists() in low-hang…
d48c6ee
…ing fruit in Factories::locateClass()
@samsonasik@dcaswel
use --update-with-dependencies on composer remove command
3c057c6
@samsonasik@dcaswel
remove deprecated --update-with-dependencies in composer remove command
62c5ee7
@samsonasik@dcaswel
one liner composer remove --dev
d0396af
@paulbalandan@dcaswel
Optimize Model
532e203
@michalsn@dcaswel
Fix orderBy() random for SQLite3
385321b
@samsonasik@dcaswel
report coveralls only in specific php version
c9ba4ac
@samsonasik@michalsn@dcaswel
add DB to COVERALLS_FLAG_NAME
e8570e5
Co-authored-by: Michal Sniatala <michal@sniatala.pl>
@samsonasik@dcaswel
restore coveralls-finish
67b8eb8
@samsonasik@dcaswel
remove if matrix.php-versions inside coveralls-finish job
fbe3a9e
@MGatner@dcaswel
Cache loaded helpers
9708c13
@MGatner@dcaswel
Add test to verify helper cache
cf4a3f0
@michalsn@dcaswel
Fix typo in phpunit action
f774850
@eSkiSo@dcaswel
getSize() does not accept parameters like getSizeByUnit()
44bac86
getSize() does not accept the unit parameter like getSizeByUnit() as stated on the user guide.
Not sure if that is suposed to be like that or it was a "copy/paste" issue on this document, but does induce into error.
@samsonasik@dcaswel
apply Option::ENABLE_CACHE to rector config
076df57
@samsonasik@dcaswel
run rector when configuration changed
b9ed474
@MGatner@dcaswel
Update time.rst
ee0ae92
@dcaswel
Combined 2 if blocks that were doing the same thing.
baad53c
@samsonasik
samsonasik
commented
Oct 18, 2020

Copy link


Copy Markdown

Member
@caswell-wc It seems you messed up the rebase, better to make backup branch, back to this branch, reset all, rebase again, and cherry-pick your own commits.
@paulbalandan
paulbalandan
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
What's the status of this PR?
@MGatner
MGatner
commented
Nov 17, 2020

Copy link


Copy Markdown

Member
@caswell-wc just wrapped up another outstanding PR so hopefully he is looking at this soon. This is possibly resolved by #3864.
@dcaswel
dcaswel
commented
Nov 18, 2020

Copy link


Copy Markdown

ContributorAuthor
This request got pretty messed up and was a really small change so I'm closing it and will recreate it with a fresh fork.
@dcasweldcaswel
closed this
Nov 18, 2020
@dcaswel
dcaswel
deleted the

request-from-filters

branch
November 18, 2020 02:40
@dcasweldcaswel
mentioned this pull request
Nov 18, 2020
 Merged

5 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik left review comments
@michalsnmichalsnmichalsn requested changes
@MGatnerMGatnerMGatner requested changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

18 participants

@dcaswel@samsonasik@paulbalandan@MGatner@michalsn@lefuentes@nyufeng@devorama@agungsugiarto@lf-uraku-yuki@sba@InsiteFX@savasdersimcelik@keradus@MisterDuval@mostafakhudair@lighthinkstudio@eSkiSo