Add MockFilters for feature testing

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.

[MGatner]

Description
Filters can return a ResponseInterface directly, which bypasses feature testing's buffer handling and causes CLI output. This PR adds a new MockFilters which intercepts responses and starts a new buffer predictively to prevent output (the buffer will be closed shortly after by FeatureTestTrait.

Checklist:

• Securely signed commits
• Component(s) with PHPdocs
• Unit testing, with >80% coverage
• n/a User guide updated
• Conforms to style guide

[MGatner]

Probably finding a way to incorporate MockResponse into feature tests would be better but our whole FeatureTestTrait revolves around gathering buffered output, so mark it as "to do" for somewhere down the road...

[paulbalandan]

We need a few tests for this.

Quick question. Since this is preventing output to be printed in the CLI, does the CITestStreamFilter can't do the same? In the spark commands tests we use that class to capture output printed in the CLI so I am thinking maybe it can do the same here.

[MGatner]

That's a good question: I'm not sure. The problem isn't so much that there is output, but rathe that feature tests may have endpoints which use Filters that return a Response directly. In CodeIgniter.php if this is detected it will send the response immediately, causing it to be written out.

I think we would still need some way to interrupt that process, since plenty of feature tests write output, just not directly. But I will look into it more.

[MGatner]

Actually digging through the "why" right now I think that the filter response in CodeIgniter.PHP should be amended to respect $returnResponse.

[MGatner]

Superseded by a PR with a more appropriate solution.