Fix: Debug toolbar selectors

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.

[iRedds]

Description
#5541

Selectors are not unique, and elements are searched throughout the document, so there might be a conflict.

Document object replaced with toobar fragment

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[kenjis]

Probably because of this PR, debug toolbar does not show up, if I click the icon.

Uncaught TypeError: this.toolbar is undefined
showTab http://localhost:8080/ line 37 > injectedScript:92
createListeners http://localhost:8080/ line 37 > injectedScript:64
init http://localhost:8080/ line 37 > injectedScript:21
onreadystatechange http://localhost:8080/index.php?debugbar:49
loadDoc http://localhost:8080/index.php?debugbar:14
EventListener.handleEvent* http://localhost:8080/index.php?debugbar:1
line 37 > injectedScript:92:14

[paulbalandan]

I think the fix would be to call ciDebugbar.init() in the js. But I don't know where to place it.

[iRedds]

@paulbalandan Calling the showTab method changes the context (this = a instead of this = ciDebugBar) if the method is called not directly, but as an "internal call".
Don't understand how i missed this.
Now my question is how to fix this correctly? New PR?

[kenjis]

@iRedds There is no other way than new PR.