Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Allow for custom exception handlers. by lonnieezell · Pull Request #5675 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/Config/Exceptions.php
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Config;

use CodeIgniter\Config\BaseConfig;
use Throwable;

/**
* Setup how the exception handler works.
Expand DownExpand Up@@ -57,4 +58,29 @@ class Exceptions extends BaseConfig
* @var array
*/
public $sensitiveDataInTrace = [];

/**
* --------------------------------------------------------------------------
* DEFINE THE HANDLERS USED
* --------------------------------------------------------------------------
* Given the HTTP status code, returns exception handler that
* should be used to deal with this error. By default, it will run CodeIgniter's
* default handler and display the error information in the expected format
* for CLI, HTTP, or AJAX requests, as determined by is_cli() and the expected
* response format.
*
* Custom handlers can be returned if you want to handle one or more specific
* error codes yourself like:
*
* if (in_array($statusCode, [400, 404, 500])) {
* return new \App\Libraries\MyExceptionHandler();
* }
* if ($exception instanceOf PageNotFoundException) {
* return new \App\Libraries\MyExceptionHandler();
* }
Comment on lines +78 to +80

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR implies handling of unhandled exceptions, but PageNotFoundException is handled separately.
Therefore, the mention of PageNotFoundException can be misleading.

*/
public function handler(int $statusCode, Throwable $exception)
{
return new \CodeIgniter\Debug\ExceptionHandler();
}
}
6 changes: 3 additions & 3 deletions phpstan-baseline.neon.dist
Original file line numberDiff line numberDiff line change
Expand Up@@ -483,12 +483,12 @@ parameters:
-
message: "#^Expression on left side of \\?\\? is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property CodeIgniter\\\\Debug\\\\Exceptions\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
message: "#^Property CodeIgniter\\\\Debug\\\\BaseExceptionHandler\\:\\:\\$formatter \\(CodeIgniter\\\\Format\\\\FormatterInterface\\) in isset\\(\\) is not nullable\\.$#"
count: 1
path: system/Debug/Exceptions.php
path: system/Debug/BaseExceptionHandler.php

-
message: "#^Property Config\\\\Exceptions\\:\\:\\$sensitiveDataInTrace \\(array\\) in isset\\(\\) is not nullable\\.$#"
Expand Down
311 changes: 311 additions & 0 deletions system/Debug/BaseExceptionHandler.php
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,311 @@
<?php

/**
* This file is part of CodeIgniter 4 framework.
*
* (c) CodeIgniter Foundation <admin@codeigniter.com>
*
* For the full copyright and license information, please view
* the LICENSE file that was distributed with this source code.
*/

namespace CodeIgniter\Debug;

use CodeIgniter\API\ResponseTrait;
use CodeIgniter\HTTP\RequestInterface;
use CodeIgniter\HTTP\Response;
use Throwable;

/**
* Provides common functions for exception handlers,
* especially around displaying the output.
*/
abstract class BaseExceptionHandler
{
use ResponseTrait;

/**
* Nesting level of the output buffering mechanism
*/
protected int $obLevel;

protected int $statusCode;
protected Throwable $exception;
protected string $view;
protected RequestInterface $request;
protected Response $response;
protected string $viewPath;
protected int $exitCode;

public function __construct()
{
$this->obLevel = ob_get_level();
$this->viewPath = rtrim(config('Exceptions')->errorViewPath, '\\/ ') . DIRECTORY_SEPARATOR;
}

/**
* The main entry point into the handler.
*
* @return mixed
*/
abstract public function handle();

/**
* Set the HTTP status code that is being thrown.
*
* @return $this
*/
public function setStatusCode(int $statusCode)
{
$this->statusCode = $statusCode;

return $this;
}

/**
* Set the exception that was originally thrown.
*
* @return $this
*/
public function setException(Throwable $exception)
{
$this->exception = $exception;

return $this;
}

/**
* Set the request used.
*
* @return $this
*/
public function setRequest(RequestInterface $request)
{
$this->request = $request;

return $this;
}

/**
* Sets the response that will be used
*
* @return $this
*/
public function setResponse(Response $response)
{
$this->response = $response;

return $this;
}

/**
* Sets the exit code that should be used when exiting the script.
*
* @return $this
*/
public function setExitCode(int $code)
{
$this->exitCode = $code;

return $this;
}

/**
* Gathers the variables that will be made available to the view.
*/
protected function collectVars(Throwable $exception, int $statusCode): array
{
$trace = $exception->getTrace();

if (config('Exceptions')->sensitiveDataInTrace !== []) {
$this->maskSensitiveData($trace, config('Exceptions')->sensitiveDataInTrace);
}

return [
'title' => get_class($exception),
'type' => get_class($exception),
'code' => $statusCode,
'message' => $exception->getMessage() ?? '(null)',
'file' => $exception->getFile(),
'line' => $exception->getLine(),
'trace' => $trace,
];
}

/**
* Mask sensitive data in the trace.
*
* @param array|object $trace
*/
protected function maskSensitiveData(&$trace, array $keysToMask, string $path = '')
{
foreach ($keysToMask as $keyToMask) {
$explode = explode('/', $keyToMask);
$index = end($explode);

if (strpos(strrev($path . '/' . $index), strrev($keyToMask)) === 0) {
if (is_array($trace) && array_key_exists($index, $trace)) {
$trace[$index] = '******************';
} elseif (is_object($trace) && property_exists($trace, $index) && isset($trace->{$index})) {
$trace->{$index} = '******************';
}
}
}

if (is_object($trace)) {
$trace = get_object_vars($trace);
}

if (is_array($trace)) {
foreach ($trace as $pathKey => $subarray) {
$this->maskSensitiveData($subarray, $keysToMask, $path . '/' . $pathKey);
}
}
}

/**
* Describes memory usage in real-world units. Intended for use
* with memory_get_usage, etc.
*/
protected static function describeMemory(int $bytes): string
{
if ($bytes < 1024) {
return $bytes . 'B';
}

if ($bytes < 1_048_576) {
return round($bytes / 1024, 2) . 'KB';
}

return round($bytes / 1_048_576, 2) . 'MB';
}

/**
* Creates a syntax-highlighted version of a PHP file.
*
* @return bool|string
*/
protected static function highlightFile(string $file, int $lineNumber, int $lines = 15)
{
if (empty($file) || ! is_readable($file)) {
return false;
}

// Set our highlight colors:
if (function_exists('ini_set')) {
ini_set('highlight.comment', '#767a7e; font-style: italic');
ini_set('highlight.default', '#c7c7c7');
ini_set('highlight.html', '#06B');
ini_set('highlight.keyword', '#f1ce61;');
ini_set('highlight.string', '#869d6a');
}

try {
$source = file_get_contents($file);
} catch (Throwable $e) {
return false;
}

$source = str_replace(["\r\n", "\r"], "\n", $source);
$source = explode("\n", highlight_string($source, true));
$source = str_replace('<br />', "\n", $source[1]);
$source = explode("\n", str_replace("\r\n", "\n", $source));

// Get just the part to show
$start = max($lineNumber - (int) round($lines / 2), 0);

// Get just the lines we need to display, while keeping line numbers...
$source = array_splice($source, $start, $lines, true);

// Used to format the line number in the source
$format = '% ' . strlen((string) ($start + $lines)) . 'd';

$out = '';
// Because the highlighting may have an uneven number
// of open and close span tags on one line, we need
// to ensure we can close them all to get the lines
// showing correctly.
$spans = 1;

foreach ($source as $n => $row) {
$spans += substr_count($row, '<span') - substr_count($row, '</span');
$row = str_replace(["\r", "\n"], ['', ''], $row);

if (($n + $start + 1) === $lineNumber) {
preg_match_all('#<[^>]+>#', $row, $tags);

$out .= sprintf(
"<span class='line highlight'><span class='number'>{$format}</span> %s\n</span>%s",
$n + $start + 1,
strip_tags($row),
implode('', $tags[0])
);
} else {
$out .= sprintf('<span class="line"><span class="number">' . $format . '</span> %s', $n + $start + 1, $row) . "\n";
}
}

if ($spans > 0) {
$out .= str_repeat('</span>', $spans);
}

return '<pre><code>' . $out . '</code></pre>';
}

/**
* Given an exception and status code will display the error to the client.
*
* @param mixed|null $viewFile
*/
protected function render($viewFile = null)
{
if (empty($viewFile) || ! is_file($viewFile)) {
echo 'The error view files were not found. Cannot render exception trace.';

exit(1);
}

if (ob_get_level() > $this->obLevel + 1) {
ob_end_clean();
}

$exception = $this->exception;
$statusCode = $this->statusCode;

echo(function () use ($exception, $statusCode, $viewFile): string {
$vars = $this->collectVars($exception, $statusCode);
extract($vars, EXTR_SKIP);

ob_start();
include $viewFile;

return ob_get_clean();
})();
}

/**
* This makes nicer looking paths for the error output.
*/
public static function cleanPath(string $file): string
{
switch (true) {
case strpos($file, APPPATH) === 0:
$file = 'APPPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(APPPATH));
break;

case strpos($file, SYSTEMPATH) === 0:
$file = 'SYSTEMPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(SYSTEMPATH));
break;

case strpos($file, FCPATH) === 0:
$file = 'FCPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(FCPATH));
break;

case defined('VENDORPATH') && strpos($file, VENDORPATH) === 0:
$file = 'VENDORPATH' . DIRECTORY_SEPARATOR . substr($file, strlen(VENDORPATH));
break;
}

return $file;
}
}
Loading