Skip to content

refactor: system/bootstrap.php only loads files and registers autoloader - #5972

Merged
kenjis merged 11 commits into
codeigniter4:developfrom
kenjis:refactor-bootstrap
May 17, 2022
Merged

refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom
kenjis:refactor-bootstrap

Conversation

@kenjis

@kenjiskenjis commented May 7, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Description
When we want to use Preloading, we need CI4 Autoloader.
But it is not easy to make the Autoloader work fine.
If you use this system/bootstrap.php, you can make it a bit easily.

  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis added the refactor Pull requests that refactor code label May 7, 2022
@kenjis
kenjis marked this pull request as draft May 7, 2022 03:50
@kenjis
kenjisforce-pushed the refactor-bootstrap branch from 2a49891 to 71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis changed the title refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis changed the title refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis changed the title refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed the refactor-bootstrap branch 2 times, most recently from 46e4f8f to 5cba764CompareMay 7, 2022 04:56
MGatner
MGatner reviewed May 7, 2022
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.

I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?

@kenjiskenjis added the breaking change Pull requests that may break existing functionalities label May 7, 2022
@kenjis
kenjisforce-pushed the refactor-bootstrap branch from 98b0d40 to c7733a5CompareMay 7, 2022 23:43
@kenjis

kenjis commented May 7, 2022

Copy link
Copy Markdown
MemberAuthor

I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?

Yes. I added the changelog and upgrade guide.

@kenjis
kenjis marked this pull request as ready for review May 7, 2022 23:45
@kenjis
kenjisforce-pushed the refactor-bootstrap branch from c7733a5 to 916d74bCompareMay 8, 2022 00:12
@kenjiskenjis mentioned this pull request May 8, 2022
Merged
4 tasks
MGatner
MGatner approved these changes May 10, 2022
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.

One phrasing suggestion, and let's make sure @lonnieezell has seen this one.

Comment threaduser_guide_src/source/installation/upgrade_420.rst Outdated
@kenjis
kenjis requested a review from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan reviewed May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst Outdated
lonnieezell
lonnieezell reviewed May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst Outdated
lonnieezell
lonnieezell approved these changes May 16, 2022
View reviewed changes

@lonnieezelllonnieezell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.

@kenjis
kenjisforce-pushed the refactor-bootstrap branch from ec95551 to d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis requested a review from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis merged commit 8ddc566 into codeigniter4:developMay 17, 2022
@kenjis
kenjis deleted the refactor-bootstrap branch May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
refactor: `system/bootstrap.php` only loads files and registers autoloader by kenjis · Pull Request #5972 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/bootstrap.php only loads files and registers autoloader - #5972
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
May 17, 2022
Merged
refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
Conversation
@kenjis
@kenjiskenjis
commented
May 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

When we want to use Preloading, we need CI4 Autoloader.

But it is not easy to make the Autoloader work fine.

If you use this system/bootstrap.php, you can make it a bit easily.
  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
May 7, 2022
@kenjis
kenjis
marked this pull request as draft
May 7, 2022 03:50
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
2a49891 to
71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis
changed the title
refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
2 times, most recently
from
46e4f8f to
5cba764CompareMay 7, 2022 04:56
MGatner
MGatner
reviewed
May 7, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
@kenjiskenjis
added
the 
breaking change
Pull requests that may break existing functionalities
label
May 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
98b0d40 to
c7733a5CompareMay 7, 2022 23:43
@kenjis
kenjis
commented
May 7, 2022

Copy link


Copy Markdown

MemberAuthor
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide.
@kenjis
kenjis
marked this pull request as ready for review
May 7, 2022 23:45
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
c7733a5 to
916d74bCompareMay 8, 2022 00:12
@kenjiskenjis
mentioned this pull request
May 8, 2022
 Merged

4 tasks
MGatner
MGatner
approved these changes
May 10, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

@kenjis
kenjis
requested a review
from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst
Outdated

lonnieezell
lonnieezell
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

lonnieezell
lonnieezell
approved these changes
May 16, 2022
View reviewed changes
@lonnieezelllonnieezell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
ec95551 to
d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis
requested a review
from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis
merged commit 8ddc566
into
codeigniter4:developMay 17, 2022
@kenjis
kenjis
deleted the

refactor-bootstrap

branch
May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: `system/bootstrap.php` only loads files and registers autoloader by kenjis · Pull Request #5972 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/bootstrap.php only loads files and registers autoloader - #5972
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
May 17, 2022
Merged
refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
Conversation
@kenjis
@kenjiskenjis
commented
May 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

When we want to use Preloading, we need CI4 Autoloader.

But it is not easy to make the Autoloader work fine.

If you use this system/bootstrap.php, you can make it a bit easily.
  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
May 7, 2022
@kenjis
kenjis
marked this pull request as draft
May 7, 2022 03:50
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
2a49891 to
71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis
changed the title
refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
2 times, most recently
from
46e4f8f to
5cba764CompareMay 7, 2022 04:56
MGatner
MGatner
reviewed
May 7, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
@kenjiskenjis
added
the 
breaking change
Pull requests that may break existing functionalities
label
May 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
98b0d40 to
c7733a5CompareMay 7, 2022 23:43
@kenjis
kenjis
commented
May 7, 2022

Copy link


Copy Markdown

MemberAuthor
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide.
@kenjis
kenjis
marked this pull request as ready for review
May 7, 2022 23:45
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
c7733a5 to
916d74bCompareMay 8, 2022 00:12
@kenjiskenjis
mentioned this pull request
May 8, 2022
 Merged

4 tasks
MGatner
MGatner
approved these changes
May 10, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

@kenjis
kenjis
requested a review
from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst
Outdated

lonnieezell
lonnieezell
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

lonnieezell
lonnieezell
approved these changes
May 16, 2022
View reviewed changes
@lonnieezelllonnieezell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
ec95551 to
d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis
requested a review
from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis
merged commit 8ddc566
into
codeigniter4:developMay 17, 2022
@kenjis
kenjis
deleted the

refactor-bootstrap

branch
May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: `system/bootstrap.php` only loads files and registers autoloader by kenjis · Pull Request #5972 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/bootstrap.php only loads files and registers autoloader - #5972
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
May 17, 2022
Merged
refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
Conversation
@kenjis
@kenjiskenjis
commented
May 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

When we want to use Preloading, we need CI4 Autoloader.

But it is not easy to make the Autoloader work fine.

If you use this system/bootstrap.php, you can make it a bit easily.
  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
May 7, 2022
@kenjis
kenjis
marked this pull request as draft
May 7, 2022 03:50
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
2a49891 to
71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis
changed the title
refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
2 times, most recently
from
46e4f8f to
5cba764CompareMay 7, 2022 04:56
MGatner
MGatner
reviewed
May 7, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
@kenjiskenjis
added
the 
breaking change
Pull requests that may break existing functionalities
label
May 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
98b0d40 to
c7733a5CompareMay 7, 2022 23:43
@kenjis
kenjis
commented
May 7, 2022

Copy link


Copy Markdown

MemberAuthor
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide.
@kenjis
kenjis
marked this pull request as ready for review
May 7, 2022 23:45
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
c7733a5 to
916d74bCompareMay 8, 2022 00:12
@kenjiskenjis
mentioned this pull request
May 8, 2022
 Merged

4 tasks
MGatner
MGatner
approved these changes
May 10, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

@kenjis
kenjis
requested a review
from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst
Outdated

lonnieezell
lonnieezell
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

lonnieezell
lonnieezell
approved these changes
May 16, 2022
View reviewed changes
@lonnieezelllonnieezell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
ec95551 to
d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis
requested a review
from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis
merged commit 8ddc566
into
codeigniter4:developMay 17, 2022
@kenjis
kenjis
deleted the

refactor-bootstrap

branch
May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
refactor: `system/bootstrap.php` only loads files and registers autoloader by kenjis · Pull Request #5972 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/bootstrap.php only loads files and registers autoloader - #5972
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
May 17, 2022
Merged
refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
Conversation
@kenjis
@kenjiskenjis
commented
May 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

When we want to use Preloading, we need CI4 Autoloader.

But it is not easy to make the Autoloader work fine.

If you use this system/bootstrap.php, you can make it a bit easily.
  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
May 7, 2022
@kenjis
kenjis
marked this pull request as draft
May 7, 2022 03:50
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
2a49891 to
71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis
changed the title
refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
2 times, most recently
from
46e4f8f to
5cba764CompareMay 7, 2022 04:56
MGatner
MGatner
reviewed
May 7, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
@kenjiskenjis
added
the 
breaking change
Pull requests that may break existing functionalities
label
May 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
98b0d40 to
c7733a5CompareMay 7, 2022 23:43
@kenjis
kenjis
commented
May 7, 2022

Copy link


Copy Markdown

MemberAuthor
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide.
@kenjis
kenjis
marked this pull request as ready for review
May 7, 2022 23:45
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
c7733a5 to
916d74bCompareMay 8, 2022 00:12
@kenjiskenjis
mentioned this pull request
May 8, 2022
 Merged

4 tasks
MGatner
MGatner
approved these changes
May 10, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

@kenjis
kenjis
requested a review
from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst
Outdated

lonnieezell
lonnieezell
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

lonnieezell
lonnieezell
approved these changes
May 16, 2022
View reviewed changes
@lonnieezelllonnieezell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
ec95551 to
d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis
requested a review
from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis
merged commit 8ddc566
into
codeigniter4:developMay 17, 2022
@kenjis
kenjis
deleted the

refactor-bootstrap

branch
May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: `system/bootstrap.php` only loads files and registers autoloader by kenjis · Pull Request #5972 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/bootstrap.php only loads files and registers autoloader - #5972
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
May 17, 2022
Merged
refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
Conversation
@kenjis
@kenjiskenjis
commented
May 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

When we want to use Preloading, we need CI4 Autoloader.

But it is not easy to make the Autoloader work fine.

If you use this system/bootstrap.php, you can make it a bit easily.
  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
May 7, 2022
@kenjis
kenjis
marked this pull request as draft
May 7, 2022 03:50
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
2a49891 to
71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis
changed the title
refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
2 times, most recently
from
46e4f8f to
5cba764CompareMay 7, 2022 04:56
MGatner
MGatner
reviewed
May 7, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
@kenjiskenjis
added
the 
breaking change
Pull requests that may break existing functionalities
label
May 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
98b0d40 to
c7733a5CompareMay 7, 2022 23:43
@kenjis
kenjis
commented
May 7, 2022

Copy link


Copy Markdown

MemberAuthor
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide.
@kenjis
kenjis
marked this pull request as ready for review
May 7, 2022 23:45
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
c7733a5 to
916d74bCompareMay 8, 2022 00:12
@kenjiskenjis
mentioned this pull request
May 8, 2022
 Merged

4 tasks
MGatner
MGatner
approved these changes
May 10, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

@kenjis
kenjis
requested a review
from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst
Outdated

lonnieezell
lonnieezell
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

lonnieezell
lonnieezell
approved these changes
May 16, 2022
View reviewed changes
@lonnieezelllonnieezell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
ec95551 to
d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis
requested a review
from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis
merged commit 8ddc566
into
codeigniter4:developMay 17, 2022
@kenjis
kenjis
deleted the

refactor-bootstrap

branch
May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
refactor: `system/bootstrap.php` only loads files and registers autoloader by kenjis · Pull Request #5972 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: system/bootstrap.php only loads files and registers autoloader - #5972
Merged
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
May 17, 2022
Merged
refactor: system/bootstrap.php only loads files and registers autoloader#5972
kenjis merged 11 commits into
codeigniter4:developfrom 
kenjis:refactor-bootstrap
Conversation
@kenjis
@kenjiskenjis
commented
May 7, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

When we want to use Preloading, we need CI4 Autoloader.

But it is not easy to make the Autoloader work fine.

If you use this system/bootstrap.php, you can make it a bit easily.
  • move CodeIgniter instantiation and DotEnv loading from system/bootstrap.php
  • tweak index.php and spark.php
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
May 7, 2022
@kenjis
kenjis
marked this pull request as draft
May 7, 2022 03:50
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
2a49891 to
71f15b7CompareMay 7, 2022 04:08
@kenjiskenjis
changed the title
refactor: move CodeIgniter instantiation from system/bootstrap.phprefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php does only load files and autoloader registerationMay 7, 2022
@kenjiskenjis
changed the title
refactor: system/bootstrap.php does only load files and autoloader registerationrefactor: system/bootstrap.php only loads files and registers autoloaderMay 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
2 times, most recently
from
46e4f8f to
5cba764CompareMay 7, 2022 04:56
MGatner
MGatner
reviewed
May 7, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have to look at this o desktop, it's a little hard on mobile to tell what moved where.
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
@kenjiskenjis
added
the 
breaking change
Pull requests that may break existing functionalities
label
May 7, 2022
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
98b0d40 to
c7733a5CompareMay 7, 2022 23:43
@kenjis
kenjis
commented
May 7, 2022

Copy link


Copy Markdown

MemberAuthor
I'm not sure the answer to this but... is changing the return of a file (bootstrap.php) considered a breaking change?
Yes. I added the changelog and upgrade guide.
@kenjis
kenjis
marked this pull request as ready for review
May 7, 2022 23:45
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
c7733a5 to
916d74bCompareMay 8, 2022 00:12
@kenjiskenjis
mentioned this pull request
May 8, 2022
 Merged

4 tasks
MGatner
MGatner
approved these changes
May 10, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand all the moves now. I don't think the bootstrap.php return is an issue - I'm actually glad we won't be relying on that anymore.
One phrasing suggestion, and let's make sure @lonnieezell has seen this one.
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

@kenjis
kenjis
requested a review
from lonnieezellMay 10, 2022 12:53
paulbalandan
paulbalandan
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.2.0.rst
Outdated

lonnieezell
lonnieezell
reviewed
May 16, 2022
View reviewed changes
Comment threaduser_guide_src/source/installation/upgrade_420.rst
Outdated

lonnieezell
lonnieezell
approved these changes
May 16, 2022
View reviewed changes
@lonnieezelllonnieezell
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it already had a couple of other approvals I didn't scan every line. I have no problems with the changes, but I do think we should let people know why the changes are happening. My first thought on reading the title of the issue was, "Why are we changing? Is there any benefit to possibly breaking people's apps for this or is it just to be "proper"?" Turns out there is a very good reason, but let's help people get to that conclusion before they get upset lol.
@kenjis
kenjisforce-pushed
the
refactor-bootstrap
branch
from
ec95551 to
d3baa55CompareMay 17, 2022 06:06
@kenjis
kenjis
requested a review
from paulbalandanMay 17, 2022 06:07
@kenjis
kenjis
merged commit 8ddc566
into
codeigniter4:developMay 17, 2022
@kenjis
kenjis
deleted the

refactor-bootstrap

branch
May 17, 2022 08:39
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lonnieezelllonnieezelllonnieezell approved these changes
@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

breaking changePull requests that may break existing functionalitiesrefactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@kenjis@lonnieezell@MGatner@paulbalandan