Skip to content

refactor: deprecate const EVENT_PRIORITY_* - #6000

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:deprecate-const-EVENT_PRIORITY
May 18, 2022
Merged

refactor: deprecate const EVENT_PRIORITY_*#6000
kenjis merged 2 commits into
codeigniter4:developfrom
kenjis:deprecate-const-EVENT_PRIORITY

Conversation

@kenjis

@kenjiskenjis commented May 17, 2022

Copy link
Copy Markdown
Member

Description
Fixes#5977

  • deprecated EVENT_PRIORITY_*
  • add Events::PRIORITY_*

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjiskenjis mentioned this pull request May 17, 2022
Closed
@kenjiskenjis added the refactor Pull requests that refactor code label May 17, 2022
@kenjiskenjis mentioned this pull request May 17, 2022
Merged
4 tasks
MGatner
MGatner approved these changes May 17, 2022
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@kenjis
kenjis merged commit 0153f4f into codeigniter4:developMay 18, 2022
@kenjis
kenjis deleted the deprecate-const-EVENT_PRIORITY branch May 18, 2022 03:12
@kenjiskenjis mentioned this pull request May 18, 2022
Merged
2 tasks
@neznaika0neznaika0 mentioned this pull request Jan 12, 2025
Merged
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatnerMGatnerMGatner approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

define() in Events

3 participants

@kenjis@MGatner@paulbalandan