feat: add request() and response()

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.

[kenjis]

Description

• add common functions

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

Ha! Now my docs on Shield work lol.

Thanks for adding these!

[iRedds]

Is it possible to know the reason for implementing these features?
In one of our discussions, your point was that the IncomingRequest class object should only be accessed in the controller.
But this implementation is contrary to your own beliefs.

The controller also has access to the Response class.

[MGatner]

These are terribly convenient. I do want to point out that we now have a global helper function wrapping a service locator wrapping a mediator (for request type). No more layers than this, please!

[kenjis]

Added the docs.

[kenjis]

@iRedds See codeigniter4/shield#417 (review)
Yes, I don't think these are good parts.
Because basically we don't need to use these in our apps.

But we have already Services::request() and service('request'),
and it seems many devs like global functions.
request() is a bit better than service('request'), because it can tell return type.

[iRedds]

I hope this is a balanced decision.
Because too much flexibility gives too many headaches to maintain a framework.