Skip to content

refactor: valid_date does not work in PHP 8.2 - #6671

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged

refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom
kenjis:fix-valid_date-php82

Conversation

@kenjis

@kenjiskenjis commented Oct 12, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Description
See #6170
See #6172 (comment)

bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjiskenjis mentioned this pull request Oct 12, 2022
Closed
7 tasks
@kenjiskenjis added the refactor Pull requests that refactor code label Oct 12, 2022
@kenjiskenjis changed the title fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik reviewed Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php Outdated
@paulbalandan

paulbalandan commented Oct 12, 2022

Copy link
Copy Markdown
Member

Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?

@kenjis
kenjisforce-pushed the fix-valid_date-php82 branch from 436fd87 to 3bafbe6CompareOctober 13, 2022 02:03
@kenjis

kenjis commented Oct 13, 2022

Copy link
Copy Markdown
MemberAuthor

Is there a case where $date is a DateTime instance yet $errors contains actual errors?

Yes.

 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],

@samsonasik
samsonasik merged commit 4887c2a into codeigniter4:developOct 13, 2022
@samsonasik

samsonasik commented Oct 13, 2022

Copy link
Copy Markdown
Member

Thank you @kenjis

@kenjis
kenjis deleted the fix-valid_date-php82 branch October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees

No one assigned

Labels

refactorPull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
refactor: valid_date does not work in PHP 8.2 by kenjis · Pull Request #6671 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: valid_date does not work in PHP 8.2 - #6671
Merged
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged
refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Conversation
@kenjis
@kenjiskenjis
commented
Oct 12, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

See #6170

See #6172 (comment)
bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  •  Conforms to style guide
@kenjiskenjis
mentioned this pull request
Oct 12, 2022

Closed

7 tasks
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Oct 12, 2022
@kenjiskenjis
changed the title
fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik
reviewed
Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php
Outdated

@paulbalandan
paulbalandan
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?
@kenjis
kenjisforce-pushed
the
fix-valid_date-php82
branch
from
436fd87 to
3bafbe6CompareOctober 13, 2022 02:03
@kenjis
kenjis
commented
Oct 13, 2022

Copy link


Copy Markdown

MemberAuthor
Is there a case where $date is a DateTime instance yet $errors contains actual errors?
Yes.
 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],
@samsonasik
samsonasik
merged commit 4887c2a
into
codeigniter4:developOct 13, 2022
@samsonasik
samsonasik
commented
Oct 13, 2022

Copy link


Copy Markdown

Member
Thank you @kenjis
@kenjis
kenjis
deleted the

fix-valid_date-php82

branch
October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: valid_date does not work in PHP 8.2 by kenjis · Pull Request #6671 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: valid_date does not work in PHP 8.2 - #6671
Merged
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged
refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Conversation
@kenjis
@kenjiskenjis
commented
Oct 12, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

See #6170

See #6172 (comment)
bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  •  Conforms to style guide
@kenjiskenjis
mentioned this pull request
Oct 12, 2022

Closed

7 tasks
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Oct 12, 2022
@kenjiskenjis
changed the title
fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik
reviewed
Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php
Outdated

@paulbalandan
paulbalandan
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?
@kenjis
kenjisforce-pushed
the
fix-valid_date-php82
branch
from
436fd87 to
3bafbe6CompareOctober 13, 2022 02:03
@kenjis
kenjis
commented
Oct 13, 2022

Copy link


Copy Markdown

MemberAuthor
Is there a case where $date is a DateTime instance yet $errors contains actual errors?
Yes.
 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],
@samsonasik
samsonasik
merged commit 4887c2a
into
codeigniter4:developOct 13, 2022
@samsonasik
samsonasik
commented
Oct 13, 2022

Copy link


Copy Markdown

Member
Thank you @kenjis
@kenjis
kenjis
deleted the

fix-valid_date-php82

branch
October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: valid_date does not work in PHP 8.2 by kenjis · Pull Request #6671 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: valid_date does not work in PHP 8.2 - #6671
Merged
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged
refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Conversation
@kenjis
@kenjiskenjis
commented
Oct 12, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

See #6170

See #6172 (comment)
bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  •  Conforms to style guide
@kenjiskenjis
mentioned this pull request
Oct 12, 2022

Closed

7 tasks
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Oct 12, 2022
@kenjiskenjis
changed the title
fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik
reviewed
Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php
Outdated

@paulbalandan
paulbalandan
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?
@kenjis
kenjisforce-pushed
the
fix-valid_date-php82
branch
from
436fd87 to
3bafbe6CompareOctober 13, 2022 02:03
@kenjis
kenjis
commented
Oct 13, 2022

Copy link


Copy Markdown

MemberAuthor
Is there a case where $date is a DateTime instance yet $errors contains actual errors?
Yes.
 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],
@samsonasik
samsonasik
merged commit 4887c2a
into
codeigniter4:developOct 13, 2022
@samsonasik
samsonasik
commented
Oct 13, 2022

Copy link


Copy Markdown

Member
Thank you @kenjis
@kenjis
kenjis
deleted the

fix-valid_date-php82

branch
October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
refactor: valid_date does not work in PHP 8.2 by kenjis · Pull Request #6671 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: valid_date does not work in PHP 8.2 - #6671
Merged
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged
refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Conversation
@kenjis
@kenjiskenjis
commented
Oct 12, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

See #6170

See #6172 (comment)
bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  •  Conforms to style guide
@kenjiskenjis
mentioned this pull request
Oct 12, 2022

Closed

7 tasks
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Oct 12, 2022
@kenjiskenjis
changed the title
fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik
reviewed
Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php
Outdated

@paulbalandan
paulbalandan
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?
@kenjis
kenjisforce-pushed
the
fix-valid_date-php82
branch
from
436fd87 to
3bafbe6CompareOctober 13, 2022 02:03
@kenjis
kenjis
commented
Oct 13, 2022

Copy link


Copy Markdown

MemberAuthor
Is there a case where $date is a DateTime instance yet $errors contains actual errors?
Yes.
 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],
@samsonasik
samsonasik
merged commit 4887c2a
into
codeigniter4:developOct 13, 2022
@samsonasik
samsonasik
commented
Oct 13, 2022

Copy link


Copy Markdown

Member
Thank you @kenjis
@kenjis
kenjis
deleted the

fix-valid_date-php82

branch
October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
refactor: valid_date does not work in PHP 8.2 by kenjis · Pull Request #6671 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: valid_date does not work in PHP 8.2 - #6671
Merged
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged
refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Conversation
@kenjis
@kenjiskenjis
commented
Oct 12, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

See #6170

See #6172 (comment)
bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  •  Conforms to style guide
@kenjiskenjis
mentioned this pull request
Oct 12, 2022

Closed

7 tasks
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Oct 12, 2022
@kenjiskenjis
changed the title
fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik
reviewed
Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php
Outdated

@paulbalandan
paulbalandan
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?
@kenjis
kenjisforce-pushed
the
fix-valid_date-php82
branch
from
436fd87 to
3bafbe6CompareOctober 13, 2022 02:03
@kenjis
kenjis
commented
Oct 13, 2022

Copy link


Copy Markdown

MemberAuthor
Is there a case where $date is a DateTime instance yet $errors contains actual errors?
Yes.
 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],
@samsonasik
samsonasik
merged commit 4887c2a
into
codeigniter4:developOct 13, 2022
@samsonasik
samsonasik
commented
Oct 13, 2022

Copy link


Copy Markdown

Member
Thank you @kenjis
@kenjis
kenjis
deleted the

fix-valid_date-php82

branch
October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
refactor: valid_date does not work in PHP 8.2 by kenjis · Pull Request #6671 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
refactor: valid_date does not work in PHP 8.2 - #6671
Merged
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Oct 13, 2022
Merged
refactor: valid_date does not work in PHP 8.2#6671
samsonasik merged 1 commit into
codeigniter4:developfrom 
kenjis:fix-valid_date-php82
Conversation
@kenjis
@kenjiskenjis
commented
Oct 12, 2022•

edited

Loading

Copy link


Copy Markdown

Member
Description

See #6170

See #6172 (comment)
bash-3.2$ ./phpunit tests/system/Validation/FormatRulesTest.phpPHPUnit 9.5.25 #StandWithUkraineRuntime: PHP 8.2.0-devConfiguration: /Users/kenji/work/codeigniter/official/CodeIgniter4/phpunit.xml............................................................... 63 / 193 ( 32%)............................................................... 126 / 193 ( 65%)............................................................... 189 / 193 ( 97%).... 193 / 193 (100%)Time: 00:00.325, Memory: 14.00 MBOK (193 tests, 193 assertions)
Checklist:
  •  Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  •  Conforms to style guide
@kenjiskenjis
mentioned this pull request
Oct 12, 2022

Closed

7 tasks
@kenjiskenjis
added
the 
refactor
Pull requests that refactor code
label
Oct 12, 2022
@kenjiskenjis
changed the title
fix: valid_date does not work in PHP 8.2refactor: valid_date does not work in PHP 8.2Oct 12, 2022
samsonasik
samsonasik
reviewed
Oct 12, 2022
View reviewed changes
Comment threadsystem/Validation/FormatRules.php
Outdated

@paulbalandan
paulbalandan
commented
Oct 12, 2022

Copy link


Copy Markdown

Member
Is there a case where $date is a DateTime instance yet $errors contains actual errors? If no, then can we remove the getLastErrors check?
@kenjis
kenjisforce-pushed
the
fix-valid_date-php82
branch
from
436fd87 to
3bafbe6CompareOctober 13, 2022 02:03
@kenjis
kenjis
commented
Oct 13, 2022

Copy link


Copy Markdown

MemberAuthor
Is there a case where $date is a DateTime instance yet $errors contains actual errors?
Yes.
 [
'1991-02-29',
'Y-m-d',
false,
],
[
'Thu, 31 Jun 2013 13:31:00',
'D, d M Y H:i:s',
false,
],
[
'2, 17, 2001',
'j, n, Y',
false,
],
[
'09-42-25, 12-00-17',
'h-i-s, j-m-y',
false,
],
@samsonasik
samsonasik
merged commit 4887c2a
into
codeigniter4:developOct 13, 2022
@samsonasik
samsonasik
commented
Oct 13, 2022

Copy link


Copy Markdown

Member
Thank you @kenjis
@kenjis
kenjis
deleted the

fix-valid_date-php82

branch
October 13, 2022 23:58
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@samsonasiksamsonasiksamsonasik approved these changes
@paulbalandanpaulbalandanpaulbalandan approved these changes

Assignees


No one assigned


Labels

refactorPull requests that refactor code

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@kenjis@paulbalandan@samsonasik