Skip to content

Turn on logging for deprecation notices by default - #6773

Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from
paulbalandan:deprecation
Nov 1, 2022
Merged

Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from
paulbalandan:deprecation

Conversation

@paulbalandan

@paulbalandanpaulbalandan commented Oct 28, 2022

Copy link
Copy Markdown
Member

Description
Following up on #6705 , this turns on the feature by default.

Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.

This PR changes the following:

  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).

Related: #6764

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis

kenjis commented Oct 28, 2022

Copy link
Copy Markdown
Member

Why does this error occur?

1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965

MGatner
MGatner reviewed Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php Outdated
Comment threadapp/Config/Exceptions.php Outdated
Comment threadapp/Config/Logger.php Outdated
@MGatner

MGatner commented Oct 28, 2022

Copy link
Copy Markdown
Member

Why does this error occur?

I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.

@MGatner

MGatner commented Oct 28, 2022

Copy link
Copy Markdown
Member

I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute

Doesn't explicitly seem like it would actually trigger a deprecation though.

@paulbalandan

paulbalandan commented Oct 28, 2022

Copy link
Copy Markdown
MemberAuthor

Why does this error occur?

Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130

When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
Merged
Merged
@MGatner

MGatner commented Oct 30, 2022

Copy link
Copy Markdown
Member

I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?

@paulbalandan

paulbalandan commented Oct 30, 2022

Copy link
Copy Markdown
MemberAuthor

I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?

I'm not sure what justification do you want for the increase in logged level. That's what remains here.

@kenjis

kenjis commented Oct 30, 2022

Copy link
Copy Markdown
Member

I don't think $threshold should be changed easily.

@paulbalandan
paulbalandanforce-pushed the deprecation branch 6 times, most recently from d8fd5e6 to 43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis reviewed Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst Outdated
@MGatner

MGatner commented Oct 31, 2022•
edited
Loading

Copy link
Copy Markdown
Member

How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9

This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.

@kenjis

kenjis commented Oct 31, 2022

Copy link
Copy Markdown
Member

It seems good! I always change it to 9 in development.

- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;

kenjis
kenjis reviewed Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst Outdated
MGatner
MGatner approved these changes Nov 1, 2022
View reviewed changes

@MGatnerMGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.

@paulbalandan
paulbalandan merged commit 2ce4b48 into codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan deleted the deprecation branch November 1, 2022 11:08
@paulbalandanpaulbalandan mentioned this pull request Mar 7, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Turn on logging for deprecation notices by default by paulbalandan · Pull Request #6773 · codeigniter4/CodeIgniter4 · GitHub
Skip to content
Turn on logging for deprecation notices by default - #6773
Merged
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Nov 1, 2022
Merged
Turn on logging for deprecation notices by default#6773
paulbalandan merged 6 commits into
codeigniter4:4.3from 
paulbalandan:deprecation
Conversation
@paulbalandan
@paulbalandanpaulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Description

Following up on #6705 , this turns on the feature by default.
Deprecation notices should not halt execution. These notices are here to notify the users that something will not work in the future. They should not be forced to fix it now.
This PR changes the following:
  • Turns on deprecation logging
  • Raise logger reporting threshold to 5
  • Use the env variable CODEIGNITER_SCREAM_DEPRECATIONS to temporarily throw deprecations in tests (for convenience rather than changing the config).
Related: #6764
Checklist:
  •  Securely signed commits
  •  Component(s) with PHPDoc blocks, only if necessary or adds value
  •  Unit testing, with >80% coverage
  •  User guide updated
  •  Conforms to style guide
@kenjis
kenjis
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
1) CodeIgniter\Cookie\CookieStoreTest::testCookieDispatching
ErrorException: The CodeIgniter\Cookie\CookieStore::setCookie method is deprecated ().
/home/runner/work/CodeIgniter4/CodeIgniter4/system/Cookie/CookieStore.php:174
/home/runner/work/CodeIgniter4/CodeIgniter4/tests/system/Cookie/CookieStoreTest.php:119
/home/runner/work/CodeIgniter4/CodeIgniter4/vendor/nexusphp/tachycardia/src/Expeditable.php:43
phpvfscomposer:///home/runner/work/CodeIgniter4/CodeIgniter4/vendor/phpunit/phpunit/phpunit:97

https://github.com/codeigniter4/CodeIgniter4/actions/runs/3343093343/jobs/5535960965
MGatner
MGatner
reviewed
Oct 28, 2022
View reviewed changes
Comment threadsystem/Debug/Exceptions.php
Outdated

Comment threadapp/Config/Exceptions.php
Outdated

Comment threadapp/Config/Logger.php
Outdated

@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
Why does this error occur?
I'm clueless! Maybe PHPUnit is trigger a deprecation warning? We know it parses docblock tags.
@MGatner
MGatner
commented
Oct 28, 2022

Copy link


Copy Markdown

Member
I didn't know this feature existed: https://phpunit.readthedocs.io/en/9.5/configuration.html#the-ignoredeprecatedcodeunits-attribute
Doesn't explicitly seem like it would actually trigger a deprecation though.
@paulbalandan
paulbalandan
commented
Oct 28, 2022

Copy link


Copy Markdown

MemberAuthor
Why does this error occur?
Apparently, PHPUnit parses @deprecated tags when mocking a method:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L123-L130
When it detects the tag, it generates the @trigger_error() in a template:
https://github.com/sebastianbergmann/phpunit/blob/851867efcbb6a1b992ec515c71cdcf20d895e9d2/src/Framework/MockObject/MockMethod.php#L205-L216

This was referenced Oct 28, 2022
 Merged

 Merged

@MGatner
MGatner
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
@paulbalandan
paulbalandan
commented
Oct 30, 2022

Copy link


Copy Markdown

MemberAuthor
I think this one has to get into 4.3 because of #6705. Is that ground for pushing on #6710 as well? When remains to be done here?
I'm not sure what justification do you want for the increase in logged level. That's what remains here.
@kenjis
kenjis
commented
Oct 30, 2022

Copy link


Copy Markdown

Member
I don't think $threshold should be changed easily.
@paulbalandan
paulbalandanforce-pushed
the
deprecation
branch
6 times, most recently
from
d8fd5e6 to
43fce71CompareOctober 30, 2022 16:18
kenjis
kenjis
reviewed
Oct 30, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

@MGatner
MGatner
commented
Oct 31, 2022•

edited

Loading

Copy link


Copy Markdown

Member
How about some way of supporting different environment-specific levels? Like if $threshold = ENVIRONMENT === 'production' ? 4 : 9
This won't affect existing installations nor current logging expectations in production, and developers can always change it in new projects.
@kenjis
kenjis
commented
Oct 31, 2022

Copy link


Copy Markdown

Member
It seems good! I always change it to 9 in development.
- public $threshold = 4;+ public $threshold = (ENVIRONMENT === 'production') ? 4 : 9;
kenjis
kenjis
reviewed
Nov 1, 2022
View reviewed changes
Comment threaduser_guide_src/source/changelogs/v4.3.0.rst
Outdated

MGatner
MGatner
approved these changes
Nov 1, 2022
View reviewed changes
@MGatnerMGatner
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks team! Very nice work @paulbalandan, glad to have this one in.
@paulbalandan
paulbalandan
merged commit 2ce4b48
into
codeigniter4:4.3Nov 1, 2022
@paulbalandan
paulbalandan
deleted the

deprecation

branch
November 1, 2022 11:08
@paulbalandanpaulbalandan
mentioned this pull request
Mar 7, 2026

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@kenjiskenjiskenjis approved these changes
@MGatnerMGatnerMGatner approved these changes

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan@kenjis@MGatner