feat: add URIFactory

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.

[kenjis]

Needs #7232

Description
Add URIFactory to create the current URI object.

To create the current URI object before the Request object. Also, to remove all URI adjustment processing currently performed in the constructor of the Request object.

This PR does not change any existing features yet.

• add URIFactory::createFromGlobals()
• add URI::setRoutePath() and URI::getRoutePath()

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[iRedds]

I don't think passing by reference, which means modifying superglobal arrays, is the right approach.

[kenjis]

What is the right approach?

[iRedds]

In my opinion, two factories are needed
\CodeIgniter\HTTP\URI::createFromRequest(Request $request) and \CodeIgniter\HTTP\URI::createFromString(string $url)

To create a separate class that works directly with _SERVER and _GET, and even created before the request object, this is not correct in my opinion.

[kenjis]

How do you create Request object without URI object?

[iRedds]

How do you create Request object without URI object?

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

[kenjis]

Say hello to the framework architects for the URI class in the Request constructor.
For the same reason, in other classes, _SERVER is also directly accessed.

Sorry, I don't get what you say at all.
Who are the framework architects?
What do you mean by say hello?

[iRedds]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Therefore, making the Request class dependent on the URI is a framework architecture error.

I don't know who designed these classes.
I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

[kenjis]

The URI class depends on the Request class for incoming requests because the Request class must provide access to a copy of _SERVER.

Indeed.

I meant that the question "How do you create Request object without URI object?" should be forwarded to those who designed.

Who designed does not matter.
The only question is how do we redesign.

[iRedds]

Who designed does not matter. The only question is how do we redesign.

I don't know.
There are two abstract options.

1. Qualitatively, but this is BC at the level of major versions.

publicfunction__constructor (protectedarray$query = [], protectedarray$request = [], protectedarray$server = []) {}
// and factorypublicstaticfunctioncreateFromGlobals(): Request {
$request = newstatic($_GET, $_REQUEST, $_SERVER);
return$request->withUri(Uri::createFromRequest($request));
}

3. Remove the restriction on $uri = null in the IncomingRequest constructor. And when null, use a request-based factory.
   

   CodeIgniter4/system/HTTP/IncomingRequest.php

   Lines 153 to 155 in 6526113

   	if (empty($uri) || empty($userAgent)) {
   	thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
   	}

if (empty($userAgent)) {
thrownewInvalidArgumentException('You must supply the parameters: uri, userAgent.');
}
$this->uri = $uri ?? URI::createFromRequest($this);

Or something similar.