fix: forbid single words as cell name input in make:cell

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.

[paulbalandan]

Description
Fixes#7472

Checklist:

• Securely signed commits
• Component(s) with PHPDoc blocks, only if necessary or adds value
• Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[lonnieezell]

This seems like the wrong fix, honestly. This is why originally the intent was to have either the class with Cell appended, or the view with _cell appended, so they were different.

I know we had a cleanup recently that I didn't get a chance to look into, but if it removed the appending from either one then that should be fixed so that one or the other gets something appended.

[kenjis]

The recent fix is #7392

@lonnieezell Do you mean the original intent is like this?

• Blog → blog_cell.php
• BlogCell → blog.php

It seems to be confusing.

The current naming rule is already complicated and I personally would like to see them simplified.
For example,

• Blog → Blog.html.php
• BlogCell → BlogCell.html.php

or

• Blog → blog.html.php
• BlogCell → blog_cell.html.php

or

• Blog → blog_cell.php
• BlogCell → blog_cell_cell.php

[lonnieezell]

The original intent was, I believe:

Controller: BlogCell.php
View: blog.php

It's nice and simple, matches what we have a tendency to do elsewhere (view is lowercased, class has function attached, like UserModel or UserController).

[kenjis]

If we follow the following rule (it is valid in the current implementation),
the classname must be two or more words.

Controller: BlogCell.php
View: blog.php

@lonnieezell
Do you want to append Cell automatically when we run make:cell Blog?

[paulbalandan]

The appending of the Cell in the controller should be controlled by the --suffix option.

[lonnieezell]

Do you want to append Cell automatically when we run make:cell Blog?

That's the way I would handle it, yes.

The appending of the Cell in the controller should be controlled by the --suffix option.

While I understand what you're saying I think it's a better experience to automatically add it then to throw and error and make them try again.

[paulbalandan]

@lonnieezell If I understand correctly, the specification would be:

$ php spark make:cell BlogCellFile created: APPPATH . 'Cells/BlogCell.php'File created: APPPATH . 'Cells/blog.php'

$ php spark make:cell AnotherFile created: APPPATH . 'Cells/AnotherCell.php'File created: APPPATH . 'Cells/another.php'

[lonnieezell]

@paulbalandan Correct.