refactor: extract ResponseCache class for Web Page Caching by kenjis · Pull Request #7644 · codeigniter4/CodeIgniter4

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis · 2023-06-30T08:30:49Z

Description

extract ResponseCache class
- to make it easier to extend the page caching
fix incorrect type definitons for request

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

iRedds · 2023-06-30T09:04:48Z

The service returns the same object. Does it make sense to create an additional property?

iRedds · 2023-06-30T22:25:53Z

I'd like to suggest a change.

Renaming a class and methods.

rename class PageCache to ResponseCache
rename method cachePage to make
rename method getCachedResponse to get

Move the CodeIgniter::$cacheTTL property to the new page caching class. That is, all functionality will be processed by one class.
The Controller::cachePage() method could then look like this.

protectedfunctioncachePage(int$time)
{
Services::pagecache()->ttl($time);
}

I don't know if it makes sense for the generateCacheKey method to be public.

kenjis · 2023-07-01T00:43:20Z

Thank you for your comment.

What about the namespace? Should be in CodeIgniter\HTTP?

iRedds · 2023-07-01T01:25:30Z

What about the namespace? Should be in CodeIgniter\HTTP?

I think the namespace should stay the same.

iRedds · 2023-07-03T04:26:10Z

+ if ($this->pageCache->getTtl() > 0) {
+ $this->pageCache->make($this->request, $this->response);
 }


Thank you for considering my suggestion, but in this snippet, I meant a slightly different approach.
Suggested change
if ($this->pageCache->getTtl() > 0) {
$this->pageCache->make($this->request, $this->response);
}
$this->pageCache->make($this->request, $this->response);
and then the decision on the need to cache the Response is made by the caching class.
publicfunction make($request, ResponseInterface$response): bool { if ($this->ttl === 0) { return ; // bool (false or true) }
This is how I see the implementation, but I don't know if my approach is correct or not.

If $ttl is 0, there is no need to cache it, so that seems a little better.
Done.

iRedds · 2023-07-03T04:34:44Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

It seems to me that the current documentation is sufficient, since in fact nothing has changed for the end developer.

Fixes the following errors: ------ ------------------------------------------------------------------ Line system/CodeIgniter.php ------ ------------------------------------------------------------------ 529 Parameter #1 $request of method CodeIgniter\Cache\PageCache::cachePage() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. 685 Parameter #1 $request of method CodeIgniter\Cache\PageCache::getCachedResponse() expects CodeIgniter\HTTP\CLIRequest|CodeIgniter\HTTP\IncomingRequest, CodeIgniter\HTTP\Request|null given. ------ ------------------------------------------------------------------

kenjis · 2023-07-03T05:18:50Z

Added changelog.

kenjis · 2023-07-03T05:23:58Z

I have a little doubt, but it seems to me that there is no point in caching the response for the CLI.

Indeed, I am not sure if there is a use case.
However, it is a feature that currently exists, so it cannot be removed all of the sudden.

Co-authored-by: MGatner <mgatner@icloud.com>

kenjis added refactor Pull requests that refactor code 4.4 labels Jun 30, 2023

kenjis marked this pull request as draft June 30, 2023 09:50

kenjis force-pushed the refactor-PageCache branch from 54ed30f to 715723dCompare June 30, 2023 11:09

kenjis added breaking change Pull requests that may break existing functionalities bug Verified issues on the current code behavior or pull requests that will fix them labels Jun 30, 2023

kenjis force-pushed the refactor-PageCache branch 2 times, most recently from 911db4e to dba3d1aCompare June 30, 2023 11:23

kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Jul 1, 2023

kenjis changed the title ~~refactor: extract PageCache class for Web Page Caching~~refactor: extract ResponseCache class for Web Page CachingJul 3, 2023

kenjis force-pushed the refactor-PageCache branch from 0da0753 to 80465c6Compare July 3, 2023 03:43

iRedds reviewed Jul 3, 2023
View reviewed changes

kenjis added 9 commits July 3, 2023 13:46

refactor: extract PageCache class
f6435c3

chore: add exemptions for CodeIgniter\Cache\PageCache
3971941

refactor: rename PageCache to ResponseCache
b2afd71

refactor: rename cachePage() to make()
d0b9868

refactor: rename getCachedResponse() to get()
8b0230a

refactor: add ResponseCache::$ttl and use it
f0748dd

test: set $_SERVER['SCRIPT_NAME']
fd4e951

refactor: don't make cahce if $ttl is 0
cd5b817

kenjis force-pushed the refactor-PageCache branch from d748ef1 to cd5b817Compare July 3, 2023 04:46

kenjis added 2 commits July 3, 2023 14:13

docs: group items of the same class
eb288ec

docs: add "Parameter Type Changes" and "Deprecations"
7d31f52

kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Jul 3, 2023

kenjis marked this pull request as ready for review July 3, 2023 05:24

MGatner requested changes Jul 3, 2023
View reviewed changes

Comment threadtests/system/CodeIgniterTest.php
Comment threaduser_guide_src/source/changelogs/v4.4.0.rst Outdated
Comment threadsystem/Cache/ResponseCache.php Outdated

docs: fix by proofreading
42ea493
Co-authored-by: MGatner <mgatner@icloud.com>

MGatner approved these changes Jul 4, 2023
View reviewed changes

refactor: make ResponseCache final
7890156

kenjis requested a review from paulbalandan July 4, 2023 22:41

paulbalandan approved these changes Jul 4, 2023
View reviewed changes

kenjis merged commit 0d15487 into codeigniter4:4.4Jul 5, 2023

kenjis deleted the refactor-PageCache branch July 5, 2023 01:52

coderabbitaiBot mentioned this pull request Jun 18, 2026
WIP: Migration to CI4 kalkun-sms/Kalkun#556
Draft