docs: fixed typo in view-parser

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome

[sammyskills]

Description
Fixed typo in view parser docs for:

• class reference for renderString()
• custom filters
• PHP native functions as filters

Checklist:

• Securely signed commits
• [] Component(s) with PHPDoc blocks, only if necessary or adds value
• [] Unit testing, with >80% coverage
• User guide updated
• Conforms to style guide

[sammyskills]

There is something I observed in the docs for PHP native functions as filters...

and its value is any valid native PHP function prefixed with:

The function actually works with/without the backslash \ prefix. Should this be indicated in the docs too?

[paulbalandan]

The \ there is to indicate you want the native str_repeat function PHP offers. This works in your case with or without the backslash because there are no user-defined function named str_repeat.

[sammyskills]

Then, I suggest it should be clearly stated in the docs, something like a "note", maybe something like this:

The \ prefix is required if there is a user-defined function named exactly the same as the PHP native function you want to use as a filter.

WDYT?

[kenjis]

The note is more confusing.

a user-defined function named exactly the same as the PHP native function

What do you mean by exactly the same? You cannot define \str_repeat(),
but can define \App\Functions\str_repeat().

All PHP native functions are defined in the global namespace.
So adding \ is harmles, and make sure you call the PHP native function.

[kenjis]

No, @sammyskills is correct.

The function actually works with/without the backslash \ prefix.

Yes. In this context, the function name is a callable.

CodeIgniter4/system/View/Parser.php

Lines 607 to 608 in 411a9bb

	// Filter it....
	$replace = $this->config->filters[$filter]($replace, ...$param);

The leading \ is not needed. It is interpreted as a full qualified function name.
See https://3v4l.org/JArO7

[kenjis]

The section title PHP Native functions as Filters is not accurate.
https://codeigniter4.github.io/CodeIgniter4/outgoing/view_parser.html#php-native-functions-as-filters
Because it does not matter whether it is a native function or not.

[sammyskills]

The section title PHP Native functions as Filters is not accurate.

That means the section will have to be removed completely, and the str_repeat example added to the examples for custom filters.

[kenjis]

Yes, all values are PHP callables.

And the first sample code is not good.

public$filters = [
'abs' => '\CodeIgniter\View\Filters::abs',
'capitalize' => '\CodeIgniter\View\Filters::capitalize',
];

\CodeIgniter\View\Filters::abs does not exist.
'capitalize' => '\CodeIgniter\View\Filters::capitalize', are already defined in CodeIgniter\Config\View.
So it is a provided filter, not custom filter.

[kenjis]

LGTM! Thank you.

[TimexPeachtree]

Awesome